Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: ipc/mojo/ipc_channel_mojo_unittest.cc

Issue 843113003: MultiProcessTest: Update SpawnChild* to return a Process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_test_base.cc ('k') | ipc/mojo/ipc_mojo_bootstrap_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/mojo/ipc_channel_mojo_unittest.cc
diff --git a/ipc/mojo/ipc_channel_mojo_unittest.cc b/ipc/mojo/ipc_channel_mojo_unittest.cc
index 2442afe34e9937cfc8d56a25364124c90a49f225..47e72fc0e5ea45d44d31d8e718ec12884b25d002 100644
--- a/ipc/mojo/ipc_channel_mojo_unittest.cc
+++ b/ipc/mojo/ipc_channel_mojo_unittest.cc
@@ -89,7 +89,7 @@ class IPCChannelMojoTest : public IPCTestBase {
bool DidStartClient() override {
bool ok = IPCTestBase::DidStartClient();
DCHECK(ok);
- host_->OnClientLaunched(client_process());
+ host_->OnClientLaunched(client_process().Handle());
return ok;
}
@@ -195,7 +195,7 @@ class IPCChannelMojoErrorTest : public IPCTestBase {
bool DidStartClient() override {
bool ok = IPCTestBase::DidStartClient();
DCHECK(ok);
- host_->OnClientLaunched(client_process());
+ host_->OnClientLaunched(client_process().Handle());
return ok;
}
@@ -269,10 +269,11 @@ class IPCChannelMojoDeadHandleTest : public IPCTestBase {
virtual bool DidStartClient() override {
IPCTestBase::DidStartClient();
- base::ProcessHandle client = client_process();
+ const base::ProcessHandle client = client_process().Handle();
// Forces GetFileHandleForProcess() fail. It happens occasionally
// in production, so we should exercise it somehow.
- ::CloseHandle(client);
+ // TODO(morrita): figure out how to safely test this.
+ // ::CloseHandle(client);
host_->OnClientLaunched(client);
return true;
}
« no previous file with comments | « ipc/ipc_test_base.cc ('k') | ipc/mojo/ipc_mojo_bootstrap_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698