Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5289)

Unified Diff: chrome/common/multi_process_lock_unittest.cc

Issue 843113003: MultiProcessTest: Update SpawnChild* to return a Process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/multi_process_lock_unittest.cc
diff --git a/chrome/common/multi_process_lock_unittest.cc b/chrome/common/multi_process_lock_unittest.cc
index 773b66e334bb0fdc11853d4dd3fa16289f75950a..9158cec75b9ad094c39bb058493ec2bebe54eec0 100644
--- a/chrome/common/multi_process_lock_unittest.cc
+++ b/chrome/common/multi_process_lock_unittest.cc
@@ -51,20 +51,20 @@ std::string MultiProcessLockTest::GenerateLockName() {
void MultiProcessLockTest::ExpectLockIsLocked(const std::string &name) {
ScopedEnvironmentVariable var(kLockEnviromentVarName, name);
- base::ProcessHandle handle = SpawnChild("MultiProcessLockTryFailMain");
- ASSERT_TRUE(handle);
+ base::Process process = SpawnChild("MultiProcessLockTryFailMain");
+ ASSERT_TRUE(process.IsValid());
int exit_code = 0;
- EXPECT_TRUE(base::WaitForExitCode(handle, &exit_code));
+ EXPECT_TRUE(process.WaitForExit(&exit_code));
EXPECT_EQ(exit_code, 0);
}
void MultiProcessLockTest::ExpectLockIsUnlocked(
const std::string &name) {
ScopedEnvironmentVariable var(kLockEnviromentVarName, name);
- base::ProcessHandle handle = SpawnChild("MultiProcessLockTrySucceedMain");
- ASSERT_TRUE(handle);
+ base::Process process = SpawnChild("MultiProcessLockTrySucceedMain");
+ ASSERT_TRUE(process.IsValid());
int exit_code = 0;
- EXPECT_TRUE(base::WaitForExitCode(handle, &exit_code));
+ EXPECT_TRUE(process.WaitForExit(&exit_code));
EXPECT_EQ(exit_code, 0);
}

Powered by Google App Engine
This is Rietveld 408576698