Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 843113003: MultiProcessTest: Update SpawnChild* to return a Process. (Closed)

Created:
5 years, 11 months ago by rvargas (doing something else)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, gavinp+memory_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, asvitkine+watch_chromium.org, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MultiProcessTest: Update SpawnChild* to return a Process. We should not be dealing with raw handles. BUG=417532 Committed: https://crrev.com/07b589c1f6c4d0aac24e270a13fa83031bf2038c Cr-Commit-Position: refs/heads/master@{#311127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -176 lines) Patch
M base/debug/stack_trace_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/metrics/stats_table_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M base/process/process_util_unittest.cc View 12 chunks +31 lines, -36 lines 0 comments Download
M base/test/multiprocess_test.h View 3 chunks +6 lines, -6 lines 0 comments Download
M base/test/multiprocess_test.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M base/test/multiprocess_test_android.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 9 chunks +17 lines, -18 lines 0 comments Download
M chrome/common/multi_process_lock_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/sandbox_mac_diraccess_unittest.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/sandbox_mac_unittest_helper.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M ipc/ipc_test_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_test_base.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_mojo_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/sync_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M sandbox/mac/bootstrap_sandbox_unittest.mm View 4 chunks +13 lines, -14 lines 0 comments Download
M sandbox/mac/xpc_message_server_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
rvargas (doing something else)
PTAL: avi -> content
5 years, 11 months ago (2015-01-10 01:10:03 UTC) #2
rvargas (doing something else)
PTAL: thestig -> base thakis -> chrome siggi -> components avi -> content agl -> ...
5 years, 11 months ago (2015-01-10 01:19:36 UTC) #4
agl
ipc LGTM.
5 years, 11 months ago (2015-01-10 01:33:12 UTC) #5
Lei Zhang
base/ lgtm
5 years, 11 months ago (2015-01-10 01:57:19 UTC) #6
Nico
chrome lgtm
5 years, 11 months ago (2015-01-10 02:43:27 UTC) #7
Hajime Morrita
ipc/mojo lgtm.
5 years, 11 months ago (2015-01-10 02:53:44 UTC) #8
Avi (use Gerrit)
lgtm Yay for OOP! 🍻
5 years, 11 months ago (2015-01-10 05:11:34 UTC) #9
Sigurður Ásgeirsson
components lgtm
5 years, 11 months ago (2015-01-10 19:49:56 UTC) #10
Robert Sesek
sandbox/ LGTM
5 years, 11 months ago (2015-01-12 17:24:20 UTC) #11
jamesr
lgtm
5 years, 11 months ago (2015-01-12 21:10:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843113003/1
5 years, 11 months ago (2015-01-12 22:18:36 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 22:23:51 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 22:25:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07b589c1f6c4d0aac24e270a13fa83031bf2038c
Cr-Commit-Position: refs/heads/master@{#311127}

Powered by Google App Engine
This is Rietveld 408576698