Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 843063005: Remove custom element upgrades. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove custom element upgrades. This removes the upgrade candidate machinery so now if an element is created before it's registered it'll never get turned into the correct type. created() callbacks and the correct wrappers being created can stil happen async though because certain operations are not safe to run script inside of (ex. the parser or editing). R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e8fec7dafc9a5226234940697e6ced5bebeaf35d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -214 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistrationContext.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementRegistrationContext.cpp View 2 chunks +2 lines, -20 lines 0 comments Download
D sky/engine/core/dom/custom/CustomElementUpgradeCandidateMap.h View 1 chunk +0 lines, -75 lines 0 comments Download
D sky/engine/core/dom/custom/CustomElementUpgradeCandidateMap.cpp View 1 chunk +0 lines, -113 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-14 00:01:00 UTC) #2
esprehn
5 years, 11 months ago (2015-01-14 00:01:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e8fec7dafc9a5226234940697e6ced5bebeaf35d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698