Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 843043004: Disable ServiceWorkerBlackBoxBrowserTest.Registration on Android. (Closed)

Created:
5 years, 11 months ago by Fabrice (no longer in Chrome)
Modified:
5 years, 11 months ago
Reviewers:
Daniel Erat, davidben
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ServiceWorkerBlackBoxBrowserTest.Registration on Android. This test is flaky on the bots. BUG=387045 Committed: https://crrev.com/6010467ce516b25455fb1eea4577b252b55a8ec9 Cr-Commit-Position: refs/heads/master@{#311746}

Patch Set 1 #

Patch Set 2 : change test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Fabrice (no longer in Chrome)
PTAL According to the bug linked, it flakes regularly on Android. Here's a recent failure: ...
5 years, 11 months ago (2015-01-15 13:54:32 UTC) #2
davidben
lgtm. (I assume the ServiceWorker people are aware of this?)
5 years, 11 months ago (2015-01-15 20:46:27 UTC) #3
Fabrice (no longer in Chrome)
On 2015/01/15 20:46:27, David Benjamin wrote: > lgtm. (I assume the ServiceWorker people are aware ...
5 years, 11 months ago (2015-01-15 20:51:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843043004/20001
5 years, 11 months ago (2015-01-15 20:51:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-15 22:57:43 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 22:59:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6010467ce516b25455fb1eea4577b252b55a8ec9
Cr-Commit-Position: refs/heads/master@{#311746}

Powered by Google App Engine
This is Rietveld 408576698