[Smart Lock] Add a private API to show an error bubble anchored to the Smart Lock app window.

[Smart Lock] Add a private API to show an error bubble anchored to the Smart Lock app window.

BUG=406439
TEST=none
R=tengs@chromium.org

Committed: https://crrev.com/f69037c6e9a0e7bc07e9d29b7bd6aaac81362e83
Cr-Commit-Position: refs/heads/master@{#313408}

[Tim Song, 2015-01-15 19:29:25]

https://codereview.chromium.org/843023002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://codereview.chromium.org/843023002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:739:
base::checked_cast<size_t>(params->link_range.end) >
Wouldn't saturated_cast be a bit safer in case size_t is say 32 bits?

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
File chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc
(right):

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc:23:
// The bubble's content area width, in device pixels.
nit: device independent pixels

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc:79:
columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::LEADING, 0,
Can't you use views::GridLayout::FIXED for the second column to avoid creating a
FixedSizeStyledLabel class?

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
File chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h
(right):

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h:24:
class ProximityAuthErrorBubbleView : public content::WebContentsObserver,
Do you need to implement content::WebContentsObserver? You don't seem to be
overriding any functions from it.

https://codereview.chromium.org/843023002/diff/20001/chrome/chrome_browser_ui...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/843023002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:810:
'browser/ui/proximity_auth/proximity_auth_error_bubble.cc',
These files aren't in the patchset. I'm guessing this is a leftover?

https://codereview.chromium.org/843023002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/843023002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:346: // |anchorRect|. If
the |link_range| is non-empty, renders the text within
Can you clarify what it means to be anchored to a rectangle? How is that
different than anchoring at a point?

[Ilya Sherman, 2015-01-16 05:39:42]

https://codereview.chromium.org/843023002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://codereview.chromium.org/843023002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:739:
base::checked_cast<size_t>(params->link_range.end) >
On 2015/01/15 19:29:24, Tim Song wrote:
> Wouldn't saturated_cast be a bit safer in case size_t is say 32 bits?

I'm pretty sure that size_t is guaranteed to be no smaller than an int.  In any
case, checked_cast would crash rather than do anything unsafe, so I don't think
there's any safety gains from using a saturated_cast.  Are there other
advantages to the saturated_cast?

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
File chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc
(right):

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc:23:
// The bubble's content area width, in device pixels.
On 2015/01/15 19:29:24, Tim Song wrote:
> nit: device independent pixels

Done.

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc:79:
columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::LEADING, 0,
On 2015/01/15 19:29:24, Tim Song wrote:
> Can't you use views::GridLayout::FIXED for the second column to avoid creating
a
> FixedSizeStyledLabel class?

Done.

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
File chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h
(right):

https://codereview.chromium.org/843023002/diff/1/chrome/browser/ui/views/prox...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h:24:
class ProximityAuthErrorBubbleView : public content::WebContentsObserver,
On 2015/01/15 19:29:24, Tim Song wrote:
> Do you need to implement content::WebContentsObserver? You don't seem to be
> overriding any functions from it.

I call web_contents(), which is null when the WebContents is being destroyed. 
This prevents a possible race condition.

https://codereview.chromium.org/843023002/diff/20001/chrome/chrome_browser_ui...
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/843023002/diff/20001/chrome/chrome_browser_ui...
chrome/chrome_browser_ui.gypi:810:
'browser/ui/proximity_auth/proximity_auth_error_bubble.cc',
On 2015/01/15 19:29:24, Tim Song wrote:
> These files aren't in the patchset. I'm guessing this is a leftover?

Whoops, forgot to git-add them.  They're used on non-ChromeOS platforms.

https://codereview.chromium.org/843023002/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/843023002/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:346: // |anchorRect|. If
the |link_range| is non-empty, renders the text within
On 2015/01/15 19:29:24, Tim Song wrote:
> Can you clarify what it means to be anchored to a rectangle? How is that
> different than anchoring at a point?

Done.

[Tim Song, 2015-01-16 22:50:37]

https://codereview.chromium.org/843023002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://codereview.chromium.org/843023002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:739:
base::checked_cast<size_t>(params->link_range.end) >
On 2015/01/16 05:39:42, Ilya Sherman wrote:
> On 2015/01/15 19:29:24, Tim Song wrote:
> > Wouldn't saturated_cast be a bit safer in case size_t is say 32 bits?
> 
> I'm pretty sure that size_t is guaranteed to be no smaller than an int.  In
any
> case, checked_cast would crash rather than do anything unsafe, so I don't
think
> there's any safety gains from using a saturated_cast.  Are there other
> advantages to the saturated_cast?

My concern is that |link_range.end| is generated as 64-bit (it's declared as
long in the idl), but size_t is 32-bit, which would cause a runtime crash on a
platform where this happens.

https://codereview.chromium.org/843023002/diff/40001/chrome/browser/extension...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://codereview.chromium.org/843023002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:796:
#if defined(OS_CHROMEOS)
Doesn't the bubble work on all desktop platforms but mac?

[Ilya Sherman, 2015-01-17 01:03:42]

https://codereview.chromium.org/843023002/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://codereview.chromium.org/843023002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:739:
base::checked_cast<size_t>(params->link_range.end) >
On 2015/01/16 22:50:36, Tim Song wrote:
> On 2015/01/16 05:39:42, Ilya Sherman wrote:
> > On 2015/01/15 19:29:24, Tim Song wrote:
> > > Wouldn't saturated_cast be a bit safer in case size_t is say 32 bits?
> > 
> > I'm pretty sure that size_t is guaranteed to be no smaller than an int.  In
> any
> > case, checked_cast would crash rather than do anything unsafe, so I don't
> think
> > there's any safety gains from using a saturated_cast.  Are there other
> > advantages to the saturated_cast?
> 
> My concern is that |link_range.end| is generated as 64-bit (it's declared as
> long in the idl), but size_t is 32-bit, which would cause a runtime crash on a
> platform where this happens.

Done.

https://codereview.chromium.org/843023002/diff/40001/chrome/browser/extension...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://codereview.chromium.org/843023002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:796:
#if defined(OS_CHROMEOS)
On 2015/01/16 22:50:36, Tim Song wrote:
> Doesn't the bubble work on all desktop platforms but mac?

Done.

[Ilya Sherman, 2015-01-17 01:05:12]

isherman@chromium.org changed reviewers:
+ sky@chromium.org, yoz@chromium.org

[Ilya Sherman, 2015-01-17 01:05:13]

+sky for //chrome/browser/ui/* and //ui/views/*
+yoz for //chrome/common/extensions/*

[Tim Song, 2015-01-17 01:53:03]

lgtm

[sky, 2015-01-20 16:24:36]

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/proxim...
File chrome/browser/ui/proximity_auth/proximity_auth_error_bubble.h (right):

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/proxim...
chrome/browser/ui/proximity_auth/proximity_auth_error_bubble.h:21: class
ProximityAuthErrorBubble {
Is there a reason you need a class here and not just a standalone function?

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/views/...
File chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h
(right):

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
2015

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h:24:
class ProximityAuthErrorBubbleView : public content::WebContentsObserver,
Don't you want to close the bubble if the WebContents you're observing is
destroyed?

In fact it isn't clear to me what lifetime this bubble is tied to.

https://codereview.chromium.org/843023002/diff/80001/ui/views/controls/styled...
File ui/views/controls/styled_label.h (right):

https://codereview.chromium.org/843023002/diff/80001/ui/views/controls/styled...
ui/views/controls/styled_label.h:99: void SizeToFit(int max_width);
Isn't this the same as:

SetSize(gfx::Size(max_width, GetHeightForWidth(max_width)) ?

[Yoyo Zhou, 2015-01-21 01:12:30]

idl LGTM

https://codereview.chromium.org/843023002/diff/80001/chrome/common/extensions...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/843023002/diff/80001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:157: // A rectangle.
What are the units?

[Ilya Sherman, 2015-01-22 02:26:27]

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/proxim...
File chrome/browser/ui/proximity_auth/proximity_auth_error_bubble.h (right):

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/proxim...
chrome/browser/ui/proximity_auth/proximity_auth_error_bubble.h:21: class
ProximityAuthErrorBubble {
On 2015/01/20 16:24:36, sky wrote:
> Is there a reason you need a class here and not just a standalone function?

Done.

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/views/...
File chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h
(right):

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
On 2015/01/20 16:24:36, sky wrote:
> 2015

Done.

https://codereview.chromium.org/843023002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.h:24:
class ProximityAuthErrorBubbleView : public content::WebContentsObserver,
On 2015/01/20 16:24:36, sky wrote:
> Don't you want to close the bubble if the WebContents you're observing is
> destroyed?
> 
> In fact it isn't clear to me what lifetime this bubble is tied to.

In theory, there shouldn't be a way for the WebContents to be destroyed while
the bubble is visible, since the bubble closes as soon as it loses focus. 
However, I've added code to close the bubble upon destruction of the associated
WebContents, just to be safe.

(In my mind, I think of the lifetime of the bubble mostly being tied to the
bubble losing focus, due to the user interacting with some other UI element. 
Please let me know if that's not a good mental model.)

https://codereview.chromium.org/843023002/diff/80001/chrome/common/extensions...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/843023002/diff/80001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:157: // A rectangle.
On 2015/01/21 01:12:30, Yoyo Zhou wrote:
> What are the units?

Done.

https://codereview.chromium.org/843023002/diff/80001/ui/views/controls/styled...
File ui/views/controls/styled_label.h (right):

https://codereview.chromium.org/843023002/diff/80001/ui/views/controls/styled...
ui/views/controls/styled_label.h:99: void SizeToFit(int max_width);
On 2015/01/20 16:24:36, sky wrote:
> Isn't this the same as:
> 
> SetSize(gfx::Size(max_width, GetHeightForWidth(max_width)) ?

Not quite.  SizeToFit will never size to a width greater than max_width, but it
will typically size to a smaller width -- whatever width is needed to fit the
text.  The result is that there isn't a bunch of awkward whitespace on the right
side of the bubble, where text could theoretically be drawn, but doesn't fit due
to word wrapping.

Note that I chose this name and max_width conventions to match the Label
implementation.

[Ilya Sherman, 2015-01-23 23:06:23]

sky@, ping :)

[sky, 2015-01-24 00:34:02]

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
File ui/views/controls/styled_label.cc (right):

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:100: width_at_last_size_calculation_(0),
AFAICT this isn't used.

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:168: 
nit: only one newline.

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:189: return calculated_size_;
How do you know this is right? Might the bounds have changed since the last
calculation?

[Ilya Sherman, 2015-01-24 00:44:32]

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
File ui/views/controls/styled_label.cc (right):

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:100: width_at_last_size_calculation_(0),
On 2015/01/24 00:34:02, sky wrote:
> AFAICT this isn't used.

It's used on line 220 below (I also added a comment there).

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:168: 
On 2015/01/24 00:34:02, sky wrote:
> nit: only one newline.

Done.

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:189: return calculated_size_;
On 2015/01/24 00:34:02, sky wrote:
> How do you know this is right? Might the bounds have changed since the last
> calculation?

AFAICT, changes to the bounds that affect the size should call Layout(), which
will update the calculated_size_.  I am not especially well-versed in Views
code, though, so perhaps I am wrong.  Is there a case that I'm overlooking?

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:220: if (width ==
width_at_last_size_calculation_ &&
width_at_last_size_calculation_ is used here.

[sky, 2015-01-26 15:49:43]

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
File ui/views/controls/styled_label.cc (right):

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:100: width_at_last_size_calculation_(0),
On 2015/01/24 00:44:32, Ilya Sherman wrote:
> On 2015/01/24 00:34:02, sky wrote:
> > AFAICT this isn't used.
> 
> It's used on line 220 below (I also added a comment there).

My mistake. Don't know how I missed it. Sorry.

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:189: return calculated_size_;
On 2015/01/24 00:44:32, Ilya Sherman wrote:
> On 2015/01/24 00:34:02, sky wrote:
> > How do you know this is right? Might the bounds have changed since the last
> > calculation?
> 
> AFAICT, changes to the bounds that affect the size should call Layout(), which
> will update the calculated_size_.

They will at some point. But there is no guarantee that it be immediate.

> I am not especially well-versed in Views
> code, though, so perhaps I am wrong.  Is there a case that I'm overlooking?

[Ilya Sherman, 2015-01-27 01:19:03]

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
File ui/views/controls/styled_label.cc (right):

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:189: return calculated_size_;
On 2015/01/26 15:49:43, sky wrote:
> On 2015/01/24 00:44:32, Ilya Sherman wrote:
> > On 2015/01/24 00:34:02, sky wrote:
> > > How do you know this is right? Might the bounds have changed since the
last
> > > calculation?
> > 
> > AFAICT, changes to the bounds that affect the size should call Layout(),
which
> > will update the calculated_size_.
> 
> They will at some point. But there is no guarantee that it be immediate.

As discussed offline, Layout() is guaranteed to be called synchronously here:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/view.cc&l...

> > I am not especially well-versed in Views
> > code, though, so perhaps I am wrong.  Is there a case that I'm overlooking?
>

https://chromiumcodereview.appspot.com/843023002/diff/120001/ui/views/control...
ui/views/controls/styled_label.cc:218: width_at_last_layout_ = width;
Scott pointed out that this was being written before being read.  Fixed in the
latest patch set.

[sky, 2015-01-27 03:40:22]

LGTM

[Ilya Sherman, 2015-01-27 21:23:54]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2015-01-27 21:24:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/843023002/150001

[commit-bot: I haz the power, 2015-01-27 21:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 21:29:12]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_gn_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ilya Sherman, 2015-01-27 22:53:06]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2015-01-27 22:53:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/843023002/170001

[commit-bot: I haz the power, 2015-01-27 23:58:26]

Committed patchset #10 (id:170001)

[commit-bot: I haz the power, 2015-01-27 23:59:53]

Patchset 10 (id:??) landed as
https://crrev.com/f69037c6e9a0e7bc07e9d29b7bd6aaac81362e83
Cr-Commit-Position: refs/heads/master@{#313408}