chrome/android/java/src/org/chromium/chrome/browser/Tab.java - Issue 843013004: Clean up onActivityStop()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 843013004: Clean up onActivityStop() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

index 811cc44a68b5629421a4ad32e856243b83b0a1df..b7b22dd765f3d1b3562c7e9d9f72ac3b72899584 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

@@ -1085,14 +1085,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

}

/**

- * Called on the foreground tab when the Activity is stopped.

- */

- // TODO(changwan): remove this

- public void onActivityStop() {

- hide();

- }

- /**

* Prepares the tab to be shown. This method is supposed to be called before the tab is

* displayed. It restores the ContentView if it is not available after the cold start and

* reloads the tab if its renderer has crashed.

« no previous file with comments | « no previous file | no next file » | no next file with comments »