Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 842963003: Enable accessing webviews for android user stories. (Closed)

Created:
5 years, 11 months ago by ariblue
Modified:
5 years, 11 months ago
Reviewers:
nednguyen, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org, slamm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable accessing webviews for android user stories. This is done by passing the android app object (which has the new GetProcesses, GetProcess, and GetWebViews functions). BUG= Committed: https://crrev.com/c1ccc77ea1f59b25c7ab383bd184c7792618cc37 Cr-Commit-Position: refs/heads/master@{#310699}

Patch Set 1 #

Total comments: 4

Patch Set 2 : pass in shared_user_story_state instead of app #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M tools/telemetry/telemetry/user_story/android/__init__.py View 1 1 chunk +1 line, -5 lines 0 comments Download
M tools/telemetry/telemetry/user_story/android/shared_app_state.py View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ariblue
5 years, 11 months ago (2015-01-08 23:11:37 UTC) #2
chrishenry
lgtm https://codereview.chromium.org/842963003/diff/1/tools/telemetry/telemetry/user_story/android/shared_app_state.py File tools/telemetry/telemetry/user_story/android/shared_app_state.py (right): https://codereview.chromium.org/842963003/diff/1/tools/telemetry/telemetry/user_story/android/shared_app_state.py#newcode57 tools/telemetry/telemetry/user_story/android/shared_app_state.py:57: # TODO(chrishenry): Implement this properly. Can you delete ...
5 years, 11 months ago (2015-01-08 23:28:10 UTC) #3
nednguyen
https://codereview.chromium.org/842963003/diff/1/tools/telemetry/telemetry/user_story/android/shared_app_state.py File tools/telemetry/telemetry/user_story/android/shared_app_state.py (right): https://codereview.chromium.org/842963003/diff/1/tools/telemetry/telemetry/user_story/android/shared_app_state.py#newcode58 tools/telemetry/telemetry/user_story/android/shared_app_state.py:58: self._current_user_story.Run(self._android_app) Hmh, can we go with the "data whale" ...
5 years, 11 months ago (2015-01-08 23:32:14 UTC) #4
ariblue
https://codereview.chromium.org/842963003/diff/1/tools/telemetry/telemetry/user_story/android/shared_app_state.py File tools/telemetry/telemetry/user_story/android/shared_app_state.py (right): https://codereview.chromium.org/842963003/diff/1/tools/telemetry/telemetry/user_story/android/shared_app_state.py#newcode57 tools/telemetry/telemetry/user_story/android/shared_app_state.py:57: # TODO(chrishenry): Implement this properly. On 2015/01/08 23:28:10, chrishenry ...
5 years, 11 months ago (2015-01-09 00:29:14 UTC) #5
nednguyen
lgtm
5 years, 11 months ago (2015-01-09 00:33:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842963003/20001
5 years, 11 months ago (2015-01-09 00:35:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-09 03:25:35 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 03:27:19 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c1ccc77ea1f59b25c7ab383bd184c7792618cc37
Cr-Commit-Position: refs/heads/master@{#310699}

Powered by Google App Engine
This is Rietveld 408576698