RenderCounter::updateCounter should trigger a relayout.

RenderCounter::updateCounter should trigger a relayout.

Currently, the method calls setTextInternal() - which updates the text
but doesn't mark the node for layout and pref widths recalc. This can
leave stale text boxes behind.

Instead, we should use setText() - which triggers the needed
invalidations.

BUG=444707
R=jbroman@chromium.org,eae@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188180

[f(malita), 2015-01-08 18:33:25]

fmalita@chromium.org changed reviewers:
+ dsinclair@chromium.org, leviw@chromium.org

[f(malita), 2015-01-08 18:46:18]

Jeremy pointed out that we're now invalidating layout while in
FrameView::layout().

Taking a closer look, I *think* this is OK: FrameView::layout() calls
updateCounters() early on, before performing the actual work (performLayout).
Hopefully a layout guru can confirm.

[f(malita), 2015-01-09 17:11:28]

fmalita@chromium.org changed reviewers:
+ jchaffraix@chromium.org

[eae, 2015-01-09 19:29:57]

This looks right to me, updateCounters ia called early enough that it should be
OK.

LGTM

[f(malita), 2015-01-10 04:21:42]

Thanks!

[f(malita), 2015-01-10 04:21:45]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-01-10 04:22:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/842913002/1

[commit-bot: I haz the power, 2015-01-10 04:26:22]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188180