Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 8429008: Prevent clang from optimizing away a variable. (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr., Hironori Bono
Visibility:
Public.

Description

Prevent clang from optimizing away a variable. It looks like clang recently learned how to optimize away more stuff. This should hopefully fix Memcheck sanity test 1. BUG=102355 TEST=Bots on the memory.fyi waterfall go green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/tools_sanity_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
(unused - use chromium)
9 years, 1 month ago (2011-10-31 16:57:45 UTC) #1
Timur Iskhodzhanov
LGTM++ Clang looks too optimal for Valgrind :)
9 years, 1 month ago (2011-10-31 17:01:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8429008/1
9 years, 1 month ago (2011-10-31 17:03:02 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
9 years, 1 month ago (2011-10-31 19:37:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8429008/1
9 years, 1 month ago (2011-10-31 19:40:40 UTC) #5
commit-bot: I haz the power
Try job failure for 8429008-1 (retry) on mac_rel for step "ui_tests" (clobber build). It's a ...
9 years, 1 month ago (2011-10-31 21:24:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8429008/1
9 years, 1 month ago (2011-11-01 09:21:48 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-01 11:08:11 UTC) #8
Change committed as 108095

Powered by Google App Engine
This is Rietveld 408576698