Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 842813002: Avoid hardcoded font families. (Closed)

Created:
5 years, 11 months ago by fukino
Modified:
5 years, 11 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid hardcoded font families. BUG=303778 TEST=check Files.app, VideoPlayer.app, and AudioPlayer.app if fonts look same. Committed: https://crrev.com/cd67920a6d1a6f91d807af50db1b2ca71290e7c5 Cr-Commit-Position: refs/heads/master@{#310743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M ui/file_manager/audio_player/audio_player.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/audio_player/css/audio_player.css View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/audio_player/elements/track_list.css View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/main.html View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/gallery/gallery.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/video_player/css/video_player.css View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/video_player/video_player.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
yoshiki@, could you take a look? Thanks! After Roboto is introduced, appropriate font family may ...
5 years, 11 months ago (2015-01-08 08:33:41 UTC) #2
yoshiki
sorry for late. lgtm
5 years, 11 months ago (2015-01-09 08:24:15 UTC) #3
fukino
On 2015/01/09 08:24:15, yoshiki wrote: > sorry for late. lgtm thanks!
5 years, 11 months ago (2015-01-09 08:24:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842813002/1
5 years, 11 months ago (2015-01-09 08:25:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 09:06:44 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 09:07:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd67920a6d1a6f91d807af50db1b2ca71290e7c5
Cr-Commit-Position: refs/heads/master@{#310743}

Powered by Google App Engine
This is Rietveld 408576698