|
|
Chromium Code Reviews
DescriptionMove some file lists in unit_tests target to variables.
This is in preparation for sharing these lists with the GN build.
There should be no functional change as a result of this.
TBR=dpranke
Committed: https://crrev.com/66b1fad300b385a86c5ffe001415316d91fb9d91
Cr-Commit-Position: refs/heads/master@{#310725}
Patch Set 1 #Patch Set 2 : fixes #Patch Set 3 : Fix Android #Patch Set 4 : merge #Patch Set 5 : Fix merge #Patch Set 6 : iFix missing comma #Messages
Total messages: 26 (13 generated)
brettw@chromium.org changed reviewers: + dpranke@google.com
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded time limit waiting for builds to trigger.
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for chrome/chrome_tests_unit.gypi:
While running git apply --index -3 -p1;
error: patch failed: chrome/chrome_tests_unit.gypi:729
Falling back to three-way merge...
Applied patch to 'chrome/chrome_tests_unit.gypi' with conflicts.
U chrome/chrome_tests_unit.gypi
Patch: chrome/chrome_tests_unit.gypi
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index
80dcdb3d9e0174d872fab994bcccf870291a4a1f..7f3c9060c1bc4ca40fb3987f7274cf842e3d4d8c
100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -4,7 +4,6 @@
{
'variables': {
'chrome_unit_tests_sources': [
- '../apps/saved_files_service_unittest.cc',
'../components/autofill/content/renderer/test_password_autofill_agent.cc',
'../components/autofill/content/renderer/test_password_autofill_agent.h',
'../components/autofill/content/renderer/test_password_generation_agent.cc',
@@ -27,25 +26,17 @@
'browser/android/mock_google_location_settings_helper.h',
'browser/android/shortcut_helper_unittest.cc',
'browser/app_controller_mac_unittest.mm',
- 'browser/apps/app_shim/app_shim_host_mac_unittest.cc',
- 'browser/apps/app_shim/extension_app_shim_handler_mac_unittest.cc',
- 'browser/apps/drive/drive_app_mapping_unittest.cc',
- 'browser/apps/ephemeral_app_service_unittest.cc',
'browser/autocomplete/autocomplete_provider_unittest.cc',
'browser/autocomplete/bookmark_provider_unittest.cc',
'browser/autocomplete/builtin_provider_unittest.cc',
'browser/autocomplete/history_quick_provider_unittest.cc',
'browser/autocomplete/history_url_provider_unittest.cc',
- 'browser/autocomplete/keyword_extensions_delegate_impl_unittest.cc',
'browser/autocomplete/search_provider_unittest.cc',
'browser/autocomplete/shortcuts_backend_unittest.cc',
'browser/autocomplete/shortcuts_database_unittest.cc',
'browser/autocomplete/shortcuts_provider_unittest.cc',
'browser/autocomplete/zero_suggest_provider_unittest.cc',
'browser/autofill/autofill_cc_infobar_delegate_unittest.cc',
- 'browser/background/background_application_list_model_unittest.cc',
- 'browser/background/background_contents_service_unittest.cc',
- 'browser/background/background_mode_manager_unittest.cc',
'browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc',
'browser/bookmarks/bookmark_html_writer_unittest.cc',
'browser/bookmarks/chrome_bookmark_client_unittest.cc',
@@ -251,7 +242,6 @@
'browser/chromeos/ui/idle_app_name_notification_view_unittest.cc',
'browser/command_updater_unittest.cc',
'browser/component_updater/test/cld_component_installer_unittest.cc',
- 'browser/component_updater/test/component_installers_unittest.cc',
'browser/component_updater/test/component_updater_service_unittest.cc',
'browser/component_updater/test/supervised_user_whitelist_installer_unittest.cc',
'browser/content_settings/content_settings_default_provider_unittest.cc',
@@ -285,162 +275,7 @@
'browser/download/download_status_updater_unittest.cc',
'browser/download/download_target_determiner_unittest.cc',
'browser/download/download_ui_controller_unittest.cc',
- 'browser/drive/drive_app_registry_unittest.cc',
- 'browser/drive/drive_api_util_unittest.cc',
- 'browser/drive/drive_uploader_unittest.cc',
- 'browser/drive/event_logger_unittest.cc',
- 'browser/drive/fake_drive_service_unittest.cc',
'browser/enumerate_modules_model_unittest_win.cc',
- 'browser/extensions/active_script_controller_unittest.cc',
- 'browser/extensions/active_tab_unittest.cc',
- 'browser/extensions/activity_log/activity_database_unittest.cc',
- 'browser/extensions/activity_log/activity_log_enabled_unittest.cc',
- 'browser/extensions/activity_log/activity_log_unittest.cc',
- 'browser/extensions/activity_log/activity_log_policy_unittest.cc',
- 'browser/extensions/activity_log/ad_injection_unittest.cc',
- 'browser/extensions/activity_log/counting_policy_unittest.cc',
- 'browser/extensions/activity_log/database_string_table_unittest.cc',
- 'browser/extensions/activity_log/fullstream_ui_policy_unittest.cc',
- 'browser/extensions/activity_log/hashed_ad_network_database_unittest.cc',
- 'browser/extensions/activity_log/uma_policy_unittest.cc',
-
'browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc',
- 'browser/extensions/api/alarms/alarms_api_unittest.cc',
- 'browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc',
-
'browser/extensions/api/content_settings/content_settings_store_unittest.cc',
- 'browser/extensions/api/content_settings/content_settings_unittest.cc',
- 'browser/extensions/api/cookies/cookies_unittest.cc',
- 'browser/extensions/api/copresence/copresence_api_unittest.cc',
- 'browser/extensions/api/declarative/rules_registry_service_unittest.cc',
-
'browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc',
- 'browser/extensions/api/declarative_content/content_action_unittest.cc',
-
'browser/extensions/api/declarative_content/content_condition_unittest.cc',
-
'browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc',
-
'browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc',
-
'browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc',
- 'browser/extensions/api/device_permissions_manager_unittest.cc',
- 'browser/extensions/api/dial/dial_device_data_unittest.cc',
- 'browser/extensions/api/dial/dial_registry_unittest.cc',
- 'browser/extensions/api/dial/dial_service_unittest.cc',
- 'browser/extensions/api/document_scan/document_scan_api_unittest.cc',
- 'browser/extensions/api/document_scan/mock_document_scan_interface.cc',
-
'browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc',
-
'browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc',
-
'browser/extensions/api/experience_sampling_private/experience_sampling_private_api_unittest.cc',
-
'browser/extensions/api/extension_action/extension_action_prefs_unittest.cc',
- 'browser/extensions/api/file_handlers/api_file_handler_util_unittest.cc',
- 'browser/extensions/api/file_handlers/mime_util_unittest.cc',
- 'browser/extensions/api/file_system/file_system_api_unittest.cc',
- 'browser/extensions/api/identity/extension_token_key_unittest.cc',
- 'browser/extensions/api/identity/gaia_web_auth_flow_unittest.cc',
- 'browser/extensions/api/identity/identity_mint_queue_unittest.cc',
- 'browser/extensions/api/idle/idle_api_unittest.cc',
-
'browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc',
-
'browser/extensions/api/image_writer_private/operation_manager_unittest.cc',
- 'browser/extensions/api/image_writer_private/operation_unittest.cc',
-
'browser/extensions/api/image_writer_private/removable_storage_provider_chromeos_unittest.cc',
- 'browser/extensions/api/image_writer_private/test_utils.cc',
-
'browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc',
-
'browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc',
- 'browser/extensions/api/log_private/syslog_parser_unittest.cc',
- 'browser/extensions/api/mdns/dns_sd_registry_unittest.cc',
-
'browser/extensions/api/messaging/native_message_process_host_unittest.cc',
-
'browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc',
-
'browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc',
- 'browser/extensions/api/omnibox/omnibox_unittest.cc',
- 'browser/extensions/api/permissions/permissions_api_helpers_unittest.cc',
- 'browser/extensions/api/preference/preference_api_prefs_unittest.cc',
- 'browser/extensions/api/proxy/proxy_api_helpers_unittest.cc',
-
'browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc',
-
'browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc',
- 'browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc',
-
'browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc',
-
'browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc',
- 'browser/extensions/api/socket/socket_api_unittest.cc',
- 'browser/extensions/api/socket/tcp_socket_unittest.cc',
- 'browser/extensions/api/socket/tls_socket_unittest.cc',
- 'browser/extensions/api/socket/udp_socket_unittest.cc',
-
'browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc',
- 'browser/extensions/api/sockets_udp/sockets_udp_api_unittest.cc',
- 'browser/extensions/api/storage/policy_value_store_unittest.cc',
- 'browser/extensions/api/storage/settings_sync_unittest.cc',
-
'browser/extensions/api/streams_private/streams_private_manifest_unittest.cc',
-
'browser/extensions/api/web_navigation/frame_navigation_state_unittest.cc',
- 'browser/extensions/api/web_request/web_request_api_unittest.cc',
- 'browser/extensions/api/web_request/web_request_permissions_unittest.cc',
- 'browser/extensions/app_sync_data_unittest.cc',
- 'browser/extensions/blacklist_state_fetcher_unittest.cc',
- 'browser/extensions/bookmark_app_helper_unittest.cc',
- 'browser/extensions/browser_permissions_policy_delegate_unittest.cc',
- 'browser/extensions/chrome_app_sorting_unittest.cc',
-
'browser/extensions/chrome_component_extension_resource_manager_unittest.cc',
- 'b…
(message too large)
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...) linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/66b1fad300b385a86c5ffe001415316d91fb9d91 Cr-Commit-Position: refs/heads/master@{#310725} |
