Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 842803002: Move some file lists in unit_tests target to variables. (Closed)

Created:
5 years, 11 months ago by brettw
Modified:
5 years, 11 months ago
Reviewers:
dpranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some file lists in unit_tests target to variables. This is in preparation for sharing these lists with the GN build. There should be no functional change as a result of this. TBR=dpranke Committed: https://crrev.com/66b1fad300b385a86c5ffe001415316d91fb9d91 Cr-Commit-Position: refs/heads/master@{#310725}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : Fix Android #

Patch Set 4 : merge #

Patch Set 5 : Fix merge #

Patch Set 6 : iFix missing comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -622 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 30 chunks +545 lines, -622 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/20001
5 years, 11 months ago (2015-01-08 08:32:18 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/43031)
5 years, 11 months ago (2015-01-08 09:01:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/40001
5 years, 11 months ago (2015-01-08 09:10:04 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 11:11:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/40001
5 years, 11 months ago (2015-01-09 02:43:16 UTC) #11
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_tests_unit.gypi: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-09 03:35:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/60001
5 years, 11 months ago (2015-01-09 03:45:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/35798) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/43464) linux_chromium_asan_rel ...
5 years, 11 months ago (2015-01-09 04:07:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/80001
5 years, 11 months ago (2015-01-09 04:19:28 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/43469)
5 years, 11 months ago (2015-01-09 04:29:37 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842803002/100001
5 years, 11 months ago (2015-01-09 06:23:50 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 11 months ago (2015-01-09 07:29:45 UTC) #25
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 07:30:38 UTC) #26
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/66b1fad300b385a86c5ffe001415316d91fb9d91
Cr-Commit-Position: refs/heads/master@{#310725}

Powered by Google App Engine
This is Rietveld 408576698