Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 842703002: Revert of Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess. (Closed)

Created:
5 years, 11 months ago by Marijn Kruisselbrink
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess. (patchset #2 id:20001 of https://codereview.chromium.org/831373002/) Reason for revert: PrcessTest.CloneWithFlags fails on Linux ChromiumOS Ozone Tests (1): http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/8139/steps/base_unittests/logs/CloneFlags ProcessTest.CloneFlags (run #1): [ RUN ] ProcessTest.CloneFlags ../../base/process/process_unittest.cc:241: Failure Value of: process.IsValid() Actual: false Expected: true [ FAILED ] ProcessTest.CloneFlags (0 ms) Original issue's description: > Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess. > > ForkWithFlags is a wrapper around the clone syscall that uses the libc > clone wrapper, and thus updates the libc's pid cache if it has one > (using sys_clone directly does not update the pid cache, so getpid may > return an incorrect result in the child). This exposes the ability to > set clone flags, which is needed to use Linux namespaces. > > BUG=312380 > > Committed: https://crrev.com/e12d6652ece2a3ab72bb05837cfd7f0b0b9ecf3a > Cr-Commit-Position: refs/heads/master@{#310327} TBR=jln@chromium.org,mdempsky@chromium.org,thestig@chromium.org,mark@chromium.org,rickyz@chromium.org NOTREECHECKS=true NOTRY=true BUG=312380 Committed: https://crrev.com/3e31085d2fe944c8fca2d2c06ca416469cc1942e Cr-Commit-Position: refs/heads/master@{#310355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -179 lines) Patch
M base/process/launch.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/process/launch_posix.cc View 1 chunk +1 line, -11 lines 0 comments Download
M base/process/process.h View 1 chunk +0 lines, -19 lines 0 comments Download
M base/process/process_linux.cc View 3 chunks +0 lines, -92 lines 0 comments Download
M base/process/process_unittest.cc View 2 chunks +0 lines, -45 lines 0 comments Download
M base/process/process_util_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/services/syscall_wrappers.h View 1 chunk +12 lines, -0 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.cc View 3 chunks +83 lines, -6 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marijn Kruisselbrink
Created Revert of Move ForkWithFlags from sandbox/ to base/ and plug it into LaunchProcess.
5 years, 11 months ago (2015-01-07 20:30:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842703002/1
5 years, 11 months ago (2015-01-07 20:32:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 20:33:59 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 20:35:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e31085d2fe944c8fca2d2c06ca416469cc1942e
Cr-Commit-Position: refs/heads/master@{#310355}

Powered by Google App Engine
This is Rietveld 408576698