Issue 842573004: [d8] Fix V8 external snapshot for Windows.

Issue 842573004: [d8] Fix V8 external snapshot for Windows. (Closed)

Created:
5 years, 11 months ago by rmcilroy

Modified:
5 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit), Erik Corry Chromium.org

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[d8] Fix V8 external snapshot for Windows. Adds a cast to V8 external snapshot code for Windows. BUG=421063, 439661 LOG=N Committed: https://crrev.com/76ce4a9c2f7dce8054f8f36263de80319f5e9509 Cr-Commit-Position: refs/heads/master@{#26024}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/d8.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (3 generated)

rmcilroy

This is required to land https://codereview.chromium.org/826083004/. PTAL, thanks.

5 years, 11 months ago (2015-01-09 21:30:41 UTC) #2

rmcilroy

On 2015/01/12 12:16:29, jochen (slow) wrote: > lgtm Thanks!

5 years, 11 months ago (2015-01-12 12:16:57 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842573004/1

5 years, 11 months ago (2015-01-12 12:17:53 UTC) #8

commit-bot: I haz the power

5 years, 11 months ago (2015-01-12 12:54:13 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/76ce4a9c2f7dce8054f8f36263de80319f5e9509
Cr-Commit-Position: refs/heads/master@{#26024}