Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 842553002: Rebuild the debug panel in the browser demo with sky. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
Reviewers:
sky, eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rebuild the debug panel in the browser demo with sky. This takes another views using debug and converts it to using sky for the view. BUG=443439 R=eseidel@chromium.org, sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f0a481669343c0c0beee257b8762e095c98141c5

Patch Set 1 #

Patch Set 2 : Hopefully fix trybots. #

Patch Set 3 : Actually delete the old implementation. #

Patch Set 4 : Add network dependency. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -239 lines) Patch
M examples/window_manager/BUILD.gn View 1 2 3 3 chunks +4 lines, -7 lines 0 comments Download
D examples/window_manager/debug_panel.h View 1 2 1 chunk +0 lines, -76 lines 0 comments Download
D examples/window_manager/debug_panel.cc View 1 2 1 chunk +0 lines, -138 lines 0 comments Download
A examples/window_manager/debug_panel.sky View 1 chunk +70 lines, -0 lines 0 comments Download
A examples/window_manager/debug_panel_host.mojom View 1 chunk +18 lines, -0 lines 0 comments Download
M examples/window_manager/window_manager.cc View 12 chunks +51 lines, -18 lines 0 comments Download
M mojo/tools/mojo_demo.py View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
Elliot Glaysher
This is my first attempt at using sky. I'm probably doing something wrong here.
5 years, 11 months ago (2015-01-07 20:15:33 UTC) #2
eseidel
lgtm This looks great! https://codereview.chromium.org/842553002/diff/50001/mojo/tools/mojo_demo.py File mojo/tools/mojo_demo.py (left): https://codereview.chromium.org/842553002/diff/50001/mojo/tools/mojo_demo.py#oldcode43 mojo/tools/mojo_demo.py:43: cmd.append('--url-mappings=mojo:window_manager=mojo:example_window_manager') You'll want to load ...
5 years, 11 months ago (2015-01-07 20:19:14 UTC) #3
sky
LGTM
5 years, 11 months ago (2015-01-07 20:23:55 UTC) #4
Elliot Glaysher
5 years, 11 months ago (2015-01-07 22:06:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:50001) manually as
f0a481669343c0c0beee257b8762e095c98141c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698