gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc - Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc

Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheck2: withoutandroidchange Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/base/metrics/cast_histograms.h ('K') | « extensions/renderer/script_context_set.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc b/gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc

index 45eeb80c543a9768783b66b0193b766c0e941475..4a9aaa7824f64ae174cd6e1bd52309beb431ebcb 100644

--- a/gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc

+++ b/gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc

@@ -37,7 +37,7 @@ const char* g_fragment_shader_source = {

void CompileShader(GLuint shader, const char* shader_source) {

glShaderSource(shader, 1, &shader_source, 0);

glCompileShader(shader);

-#if DCHECK_IS_ON

+#if DCHECK_IS_ON()

GLint compile_status = GL_FALSE;

glGetShaderiv(shader, GL_COMPILE_STATUS, &compile_status);

if (GL_TRUE != compile_status) {

@@ -119,7 +119,7 @@ void ClearFramebufferResourceManager::ClearFramebuffer(

glAttachShader(program_, fragment_shader);

glBindAttribLocation(program_, kVertexPositionAttrib, "a_position");

glLinkProgram(program_);

-#if DCHECK_IS_ON

+#if DCHECK_IS_ON()

GLint linked = GL_FALSE;

glGetProgramiv(program_, GL_LINK_STATUS, &linked);

if (GL_TRUE != linked)

@@ -132,7 +132,7 @@ void ClearFramebufferResourceManager::ClearFramebuffer(

}

glUseProgram(program_);

-#if DCHECK_IS_ON

+#if DCHECK_IS_ON()

glValidateProgram(program_);

GLint validation_status = GL_FALSE;

glGetProgramiv(program_, GL_VALIDATE_STATUS, &validation_status);