extensions/renderer/logging_native_handler.cc - Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/logging_native_handler.cc

Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheck2: withoutandroidchange Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/logging_native_handler.cc

diff --git a/extensions/renderer/logging_native_handler.cc b/extensions/renderer/logging_native_handler.cc

index 9019d86e2f8fcb03a94e1877650c2d6beb36ea30..0996a2ac67d34d4e71516c5324eb9ac67c481878 100644

--- a/extensions/renderer/logging_native_handler.cc

+++ b/extensions/renderer/logging_native_handler.cc

@@ -47,7 +47,7 @@ void LoggingNativeHandler::Dcheck(

void LoggingNativeHandler::DcheckIsOn(

const v8::FunctionCallbackInfo<v8::Value>& args) {

- args.GetReturnValue().Set(DCHECK_IS_ON);

+ args.GetReturnValue().Set(DCHECK_IS_ON());

}

void LoggingNativeHandler::Log(

« chromecast/base/metrics/cast_histograms.h ('K') | « extensions/renderer/logging_native_handler.h ('k') | extensions/renderer/script_context_set.cc » ('j') | no next file with comments »