content/browser/android/java/gin_java_bridge_dispatcher_host.cc - Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/java/gin_java_bridge_dispatcher_host.cc

Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheck2: withoutandroidchange Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/base/metrics/cast_histograms.h ('K') | « components/history/core/browser/top_sites_cache.cc ('k') | content/browser/service_worker/service_worker_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/java/gin_java_bridge_dispatcher_host.cc

diff --git a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc

index 7255920a96331e313c4b2d8e10876d9a393a9c28..93fc0c441480308440b1e72e35281e90e49fcab3 100644

--- a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc

+++ b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc

@@ -144,13 +144,13 @@ GinJavaBoundObject::ObjectID GinJavaBridgeDispatcherHost::AddObject(

base::AutoLock locker(objects_lock_);

objects_[object_id] = new_object;

}

-#if DCHECK_IS_ON

+#if DCHECK_IS_ON()

{

GinJavaBoundObject::ObjectID added_object_id;

DCHECK(FindObjectId(object, &added_object_id));

DCHECK_EQ(object_id, added_object_id);

}

-#endif // DCHECK_IS_ON

+#endif // DCHECK_IS_ON()

base::android::ScopedJavaLocalRef<jobject> retained_object_set =

retained_object_set_.get(env);

if (!retained_object_set.is_null()) {