Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2770)

Unified Diff: cc/base/completion_event.h

Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dcheck2: withoutandroidchange Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/base/completion_event.h
diff --git a/cc/base/completion_event.h b/cc/base/completion_event.h
index 96ccf5417de9d42c48ba6e28d5c56066fa1d9f62..6bae765dd20e2173065bccab670afd2618547a95 100644
--- a/cc/base/completion_event.h
+++ b/cc/base/completion_event.h
@@ -19,21 +19,21 @@ class CompletionEvent {
public:
CompletionEvent()
: event_(false /* manual_reset */, false /* initially_signaled */) {
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
waited_ = false;
signaled_ = false;
#endif
}
~CompletionEvent() {
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
DCHECK(waited_);
DCHECK(signaled_);
#endif
}
void Wait() {
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
DCHECK(!waited_);
waited_ = true;
#endif
@@ -42,7 +42,7 @@ class CompletionEvent {
}
void Signal() {
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
DCHECK(!signaled_);
signaled_ = true;
#endif
@@ -51,7 +51,7 @@ class CompletionEvent {
private:
base::WaitableEvent event_;
-#if DCHECK_IS_ON
+#if DCHECK_IS_ON()
// Used to assert that Wait() and Signal() are each called exactly once.
bool waited_;
bool signaled_;

Powered by Google App Engine
This is Rietveld 408576698