chromecast/browser/android/external_video_surface_container_impl.cc - Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/external_video_surface_container_impl.cc

Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dcheck2: macro Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/browser/android/external_video_surface_container_impl.cc

diff --git a/chromecast/browser/android/external_video_surface_container_impl.cc b/chromecast/browser/android/external_video_surface_container_impl.cc

index 8951f950fa19ae204b640a24e56b0381537f4020..e1f7e8bdab0e85916d16b713f9e89060a6ff6aa4 100644

--- a/chromecast/browser/android/external_video_surface_container_impl.cc

+++ b/chromecast/browser/android/external_video_surface_container_impl.cc

@@ -43,7 +43,7 @@ void ExternalVideoSurfaceContainerImpl::RequestExternalVideoSurface(

}

int ExternalVideoSurfaceContainerImpl::GetCurrentPlayerId() {

- JNIEnv* env = AttachCurrentThread();

+ JNIEnv* env = base::android::AttachCurrentThread();

Nico 2015/01/07 00:12:13 looks somewhat unrelated, but ok :-)

danakj 2015/01/07 04:40:17 Er. I dunno how that is there. I'll remove it befo

int current_player = static_cast<int>(

Java_ExternalVideoSurfaceContainer_getCurrentPlayerId(

« no previous file with comments | « chromecast/base/metrics/cast_histograms.h ('k') | components/history/core/browser/top_sites_cache.cc » ('j') | no next file with comments »