Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: extensions/renderer/resources/send_request.js

Issue 842523002: base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/send_request.js
diff --git a/extensions/renderer/resources/send_request.js b/extensions/renderer/resources/send_request.js
index 7cdc7d16936a19a267258e217ccc4fd0a853433c..3a2697e382dee94bc55612b5a5d429ff0373ae0d 100644
--- a/extensions/renderer/resources/send_request.js
+++ b/extensions/renderer/resources/send_request.js
@@ -65,7 +65,7 @@ function handleResponse(requestId, name, success, responseList, error) {
// caller has provided a callback. Implementations of api
// calls may not return data if they observe the caller
// has not provided a callback.
- if (logging.DCHECK_IS_ON() && !error) {
+ if (!logging.DCHECK_IS_OFF() && !error) {
if (!request.callbackSchema.parameters)
throw new Error(name + ": no callback schema defined");
validate(responseList, request.callbackSchema.parameters);

Powered by Google App Engine
This is Rietveld 408576698