base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON().

android_webview/browser/hardware_renderer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/hardware_renderer.h"
 
 #include "android_webview/browser/aw_gl_surface.h"
 #include "android_webview/browser/deferred_gpu_command_service.h"
 #include "android_webview/browser/parent_output_surface.h"
 #include "android_webview/browser/shared_renderer_state.h"
@@ skipping 99 matching lines @@
 
 HardwareRenderer::~HardwareRenderer() {
   SetFrameData();
 
   // Must reset everything before |resource_collection_| to ensure all
   // resources are returned before resetting |resource_collection_| client.
   layer_tree_host_.reset();
   root_layer_ = NULL;
   delegated_layer_ = NULL;
   frame_provider_ = NULL;
-#if DCHECK_IS_ON

[Nico, 2015/01/06 23:46:15]

Can we make DCHECK_IS_ON a function-style macro? `#if DCHECK_IS_ON()` will fail
instead of silently be 0, and we don't need double negation that way.

[danakj, 2015/01/06 23:55:10]

Oh that's a good point. I thought no, because we used to have that and it was a
problem. But that's because it resolved to code that had to execute at runtime,
not just to a constant that the preprocessor can use.

+#if !DCHECK_IS_OFF
   // Check collection is empty.
   cc::ReturnedResourceArray returned_resources;
   resource_collection_->TakeUnusedResourcesForChildCompositor(
       &returned_resources);
   DCHECK_EQ(0u, returned_resources.size());
-#endif  // DCHECK_IS_ON
+#endif  // !DCHECK_IS_OFF
 
   resource_collection_->SetClient(NULL);
 
   // Reset draw constraints.
   shared_renderer_state_->UpdateDrawConstraintsOnRT(
       ParentCompositorDrawConstraints());
 }
 
 void HardwareRenderer::DidBeginMainFrame() {
   // This is called after OutputSurface is created, but before the impl frame
@@ skipping 131 matching lines @@
 }
 
 void HardwareRenderer::UnusedResourcesAreAvailable() {
   cc::ReturnedResourceArray returned_resources;
   resource_collection_->TakeUnusedResourcesForChildCompositor(
       &returned_resources);
   shared_renderer_state_->InsertReturnedResourcesOnRT(returned_resources);
 }
 
 }  // namespace android_webview