MacViews: Disable tests in MenuViewDragAndDropTest.

MacViews: Disable tests in MenuViewDragAndDropTest.

These tests are currently disabled on Linux and Windows. They were only run
on Mac with toolkit_views:

MenuViewDragAndDropTestTestInMenuDrag.TestInMenuDrag
MenuViewDragAndDropTestNestedDrag.MenuViewDragAndDropNestedDrag

This CL disables the tests on Mac. On Windows, it makes the tests disabled
instead of if-def'd out.

BUG=449058
Committed: https://crrev.com/9b85b5bb6fbdcd6802bfa60f3a8255255597ab07
Cr-Commit-Position: refs/heads/master@{#311782}

[jackhou1, 2015-01-15 06:14:37]

jackhou@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2015-01-15 06:38:07]

https://codereview.chromium.org/842513003/diff/1/chrome/browser/ui/views/menu...
File chrome/browser/ui/views/menu_view_drag_and_drop_test.cc (right):

https://codereview.chromium.org/842513003/diff/1/chrome/browser/ui/views/menu...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:23: #if
defined(OS_LINUX) && defined(USE_AURA) || defined(OS_WIN) || defined(OS_MACOSX)
Since this is basically #if (true)... we might as well reorganise a bit. This
bit up here feels out of place.

I'd just change the two tests do say DISABLED_TestFoo, but put a comment above
them like

// ...
// to stay open.
// Disabled on all platforms for being flaky. Tracked in:
// TODO(erg): Fix DND tests on linux_aura. http://crbug.com/163931.
// Windows: http://crbug.com/401226.
// TODO(tapted): De-flake and run on Mac https://crbug.com/449058.
VIEW_TEST(MenuViewDragAndDropTestTestInMenuDrag, DISABLED_TestInMenuDrag)

/* ... */
// after the drag.
// Disabled on all platforms for being flaky. Tracked in:
// TODO(erg): Fix DND tests on linux_aura. http://crbug.com/163931.
// Windows: http://crbug.com/401226.
// TODO(tapted): De-flake and run on Mac https://crbug.com/449058.
VIEW_TEST(MenuViewDragAndDropTestNestedDrag, \
    DISABLED_MenuViewDragAndDropNestedDrag)


For mac, I wouldn't say enable these tests if they get fixed. Ideally myself, or
someone, finds time to get the test running on Mac in a non-flaky way, and
investigates de-flaking it on all platforms.

[jackhou1, 2015-01-15 06:53:28]

https://codereview.chromium.org/842513003/diff/1/chrome/browser/ui/views/menu...
File chrome/browser/ui/views/menu_view_drag_and_drop_test.cc (right):

https://codereview.chromium.org/842513003/diff/1/chrome/browser/ui/views/menu...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:23: #if
defined(OS_LINUX) && defined(USE_AURA) || defined(OS_WIN) || defined(OS_MACOSX)
On 2015/01/15 06:38:07, tapted wrote:
> Since this is basically #if (true)... we might as well reorganise a bit. This
> bit up here feels out of place.
> 
> I'd just change the two tests do say DISABLED_TestFoo, but put a comment above
> them like
> 
> // ...
> // to stay open.
> // Disabled on all platforms for being flaky. Tracked in:
> // TODO(erg): Fix DND tests on linux_aura. http://crbug.com/163931.
> // Windows: http://crbug.com/401226.
> // TODO(tapted): De-flake and run on Mac https://crbug.com/449058.
> VIEW_TEST(MenuViewDragAndDropTestTestInMenuDrag, DISABLED_TestInMenuDrag)
> 
> /* ... */
> // after the drag.
> // Disabled on all platforms for being flaky. Tracked in:
> // TODO(erg): Fix DND tests on linux_aura. http://crbug.com/163931.
> // Windows: http://crbug.com/401226.
> // TODO(tapted): De-flake and run on Mac https://crbug.com/449058.
> VIEW_TEST(MenuViewDragAndDropTestNestedDrag, \
>     DISABLED_MenuViewDragAndDropNestedDrag)
> 
> 
> For mac, I wouldn't say enable these tests if they get fixed. Ideally myself,
or
> someone, finds time to get the test running on Mac in a non-flaky way, and
> investigates de-flaking it on all platforms.

Done.

[tapted, 2015-01-15 07:13:39]

lgtm with a bunch of nits :)

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/menu_view_drag_and_drop_test.cc (right):

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
CL description nits:
prefix summary/firstline with `MacViews:`

Make it clear that a toolkit_views build on Mac is currently the *only* place
these tests run.  (e.g. say that and/or make sure it mentions that the tests
were already disabled on Linux [as well as windows]

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:343: // TODO(erg): Fix
DND tests on linux_aura. crbug.com/163931.
nit: http:// for consistency

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:345: // TODO(tapted):
De-flaky and run on Mac. https://crbug.com/449058.
nit: flaky->flake

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:445: // TODO(erg): Fix
DND tests on linux_aura. crbug.com/163931.
as above

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:447: // TODO(tapted):
De-flaky and run on Mac. https://crbug.com/449058.
as above

[jackhou1, 2015-01-15 07:21:47]

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/menu_view_drag_and_drop_test.cc (right):

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2015/01/15 07:13:39, tapted wrote:
> CL description nits:
> prefix summary/firstline with `MacViews:`
> 
> Make it clear that a toolkit_views build on Mac is currently the *only* place
> these tests run.  (e.g. say that and/or make sure it mentions that the tests
> were already disabled on Linux [as well as windows]

Done.

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:343: // TODO(erg): Fix
DND tests on linux_aura. crbug.com/163931.
On 2015/01/15 07:13:39, tapted wrote:
> nit: http:// for consistency

Done.

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:345: // TODO(tapted):
De-flaky and run on Mac. https://crbug.com/449058.
On 2015/01/15 07:13:39, tapted wrote:
> nit: flaky->flake

Done.

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:445: // TODO(erg): Fix
DND tests on linux_aura. crbug.com/163931.
On 2015/01/15 07:13:39, tapted wrote:
> as above

Done.

https://codereview.chromium.org/842513003/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/menu_view_drag_and_drop_test.cc:447: // TODO(tapted):
De-flaky and run on Mac. https://crbug.com/449058.
On 2015/01/15 07:13:39, tapted wrote:
> as above

Done.

[jackhou1, 2015-01-15 07:23:03]

jackhou@chromium.org changed reviewers:
+ sky@chromium.org

[jackhou1, 2015-01-15 07:23:03]

sky, please review for OWNERS

[sky, 2015-01-15 18:33:21]

LGTM

[jackhou1, 2015-01-15 23:09:19]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2015-01-15 23:11:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/842513003/40001

[commit-bot: I haz the power, 2015-01-16 00:38:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-16 00:40:13]

Patchset 3 (id:??) landed as
https://crrev.com/9b85b5bb6fbdcd6802bfa60f3a8255255597ab07
Cr-Commit-Position: refs/heads/master@{#311782}