content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java - Issue 842493004: [Clank IME] Make keyCode detection sensitive to autocomplete=on|off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 842493004: [Clank IME] Make keyCode detection sensitive to autocomplete=on|off. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updating unittest. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('K') | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

index f33e53c268d773e0497a2c7104302eb6acba5a51..5bfc07353b4f75196eae04bf1c4c5df72eb60d62 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

@@ -47,6 +47,7 @@ public class ImeTest extends ContentShellTestBase {

+ "<br/><textarea id=\"textarea\" rows=\"4\" cols=\"20\"></textarea>"

+ "<br/><p><span id=\"plain_text\">This is Plain Text One</span></p>"

+ "</form></body></html>");

+ private static final int COMPOSITION_KEY_CODE = 229;

private TestAdapterInputConnection mConnection;

private ImeAdapter mImeAdapter;

@@ -709,7 +710,7 @@ public class ImeTest extends ContentShellTestBase {

// H

expectUpdateStateCall(mConnection);

setComposingText(mConnection, "h", 1);

- assertEquals(KeyEvent.KEYCODE_H, mImeAdapter.mLastSyntheticKeyCode);

+ assertEquals(COMPOSITION_KEY_CODE, mImeAdapter.mLastSyntheticKeyCode);

bcwhite 2015/01/13 15:33:43 You should still test for KEYCODE_H but enable it

// Simulate switch of input fields.

finishComposingText(mConnection);

@@ -717,7 +718,7 @@ public class ImeTest extends ContentShellTestBase {

// H

expectUpdateStateCall(mConnection);

setComposingText(mConnection, "h", 1);

- assertEquals(KeyEvent.KEYCODE_H, mImeAdapter.mLastSyntheticKeyCode);

+ assertEquals(COMPOSITION_KEY_CODE, mImeAdapter.mLastSyntheticKeyCode);

}

@SmallTest