Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 842363002: NaCl: Remove disabled test, fault_injection/fault_pm_nameservice_test.cc (Closed)

Created:
5 years, 11 months ago by Mark Seaborn
Modified:
5 years, 11 months ago
CC:
chromium-reviews, teravest
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Remove disabled test, fault_injection/fault_pm_nameservice_test.cc This has been disabled since September 2011, when it got disabled for being flaky by this change: http://codereview.chromium.org/7833022 fault_pm_nameservice_test.cc depended on the SRPC services "ManifestNameService" (which we are removing) and "SecureRandom" (which we have already removed). The use of NACL_FAULT_INJECTION is pretty obscure, and is not something that we're going to try to re-enable. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST=none Committed: https://crrev.com/b6daf793a020c57f7b505d76df87a7a0a5767ef2 Cr-Commit-Position: refs/heads/master@{#310970}

Patch Set 1 #

Patch Set 2 : Other bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -470 lines) Patch
M ppapi/native_client/chrome_main.scons View 1 1 chunk +0 lines, -3 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/fault_injection/fault_pm_nameservice_test.cc View 1 chunk +0 lines, -232 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/fault_injection/fault_pm_nameservice_test.html View 1 chunk +0 lines, -70 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/fault_injection/nacl.scons View 1 chunk +0 lines, -86 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/fault_injection/no_fault_pm_nameservice_test.html View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 11 months ago (2015-01-10 02:14:53 UTC) #2
jvoung (off chromium)
LGTM thanks
5 years, 11 months ago (2015-01-10 02:35:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842363002/20001
5 years, 11 months ago (2015-01-10 05:54:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-10 06:35:07 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 06:54:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6daf793a020c57f7b505d76df87a7a0a5767ef2
Cr-Commit-Position: refs/heads/master@{#310970}

Powered by Google App Engine
This is Rietveld 408576698