DevTools: Clean up the Event Listeners pane data representation

DevTools: Clean up the Event Listeners pane data representation

Redundant pane data have been removed, handler source preview
moved into a popover triggered on the "handler" key hover.

R=lushnikov, pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189334

[pfeldman, 2015-01-19 19:19:43]

Not sure I am in agreement with this - typically we either expand on the value
using popover, or use the key: value pair. But not both. I'd rather either leave
it as is or refactored the UI more radically.

[apavlov, 2015-01-19 19:26:33]

On 2015/01/19 19:19:43, pfeldman wrote:
> Not sure I am in agreement with this - typically we either expand on the value
> using popover, or use the key: value pair. But not both. I'd rather either
leave
> it as is or refactored the UI more radically.

The popover is a source code preview for a function, not a means of property
inspection. Similar to how we show a dumped object preview in the console, which
does not interfere with the subsequent expansion of the object. That was my
concept (I agree that this UI is not quite consistent and might use some
affordance or something, but this is just a first stab.) And that's why I wanted
to sit together and think of some better approach, which would allow for a
better function text quick preview and reduced data redundancy.

[apavlov, 2015-01-21 17:24:33]

According to aandrey, we can potentially miss a script compiled during
profiling, so the scriptId in this case will not help us retrieve the respective
script sourceURL from the DebuggerModel.

[pfeldman, 2015-01-22 12:31:43]

lgtm

https://codereview.chromium.org/842323005/diff/40001/Source/devtools/protocol...
File Source/devtools/protocol.json (left):

https://codereview.chromium.org/842323005/diff/40001/Source/devtools/protocol...
Source/devtools/protocol.json:2158: { "name": "handlerBody", "type": "string",
"description": "Event handler function body." },
lets remove this.

[apavlov, 2015-02-02 11:00:29]

https://codereview.chromium.org/842323005/diff/40001/Source/devtools/protocol...
File Source/devtools/protocol.json (left):

https://codereview.chromium.org/842323005/diff/40001/Source/devtools/protocol...
Source/devtools/protocol.json:2158: { "name": "handlerBody", "type": "string",
"description": "Event handler function body." },
On 2015/01/22 12:31:43, pfeldman wrote:
> lets remove this.

Done.

[apavlov, 2015-02-02 11:00:41]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2015-02-02 11:01:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/842323005/60001

[commit-bot: I haz the power, 2015-02-02 13:00:43]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189334