Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 842323003: Switch to a more complete method of filtering hoisted layers (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix oversight w.r.t. SkPictureImageFilters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M src/gpu/GrLayerCache.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 4 chunks +16 lines, -5 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
robertphillips
5 years, 11 months ago (2015-01-13 17:31:32 UTC) #2
bsalomon
https://codereview.chromium.org/842323003/diff/1/src/gpu/GrLayerHoister.cpp File src/gpu/GrLayerHoister.cpp (left): https://codereview.chromium.org/842323003/diff/1/src/gpu/GrLayerHoister.cpp#oldcode306 src/gpu/GrLayerHoister.cpp:306: if (!device->filterTexture(context, layer->texture(), layer->filter(), Is this still used anywhere? ...
5 years, 11 months ago (2015-01-13 18:08:40 UTC) #3
robertphillips
https://codereview.chromium.org/842323003/diff/1/src/gpu/GrLayerHoister.cpp File src/gpu/GrLayerHoister.cpp (left): https://codereview.chromium.org/842323003/diff/1/src/gpu/GrLayerHoister.cpp#oldcode306 src/gpu/GrLayerHoister.cpp:306: if (!device->filterTexture(context, layer->texture(), layer->filter(), On 2015/01/13 18:08:40, bsalomon wrote: ...
5 years, 11 months ago (2015-01-13 18:28:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842323003/1
5 years, 11 months ago (2015-01-13 18:29:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/74668a8e818fd891a08c4966cc5973b04c1ad992
5 years, 11 months ago (2015-01-13 18:37:58 UTC) #7
robertphillips
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/851773002/ by robertphillips@google.com. ...
5 years, 11 months ago (2015-01-13 18:54:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842323003/20001
5 years, 11 months ago (2015-01-14 15:59:34 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 16:08:24 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/95145a9d3e0be24769c4c4e3810058e08b06fd3b

Powered by Google App Engine
This is Rietveld 408576698