Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Unified Diff: src/pdf/SkPDFCanon.h

Issue 842253003: SkPDFCanon (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/pdf.gypi ('k') | src/pdf/SkPDFCanon.cpp » ('j') | src/pdf/SkPDFCanon.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pdf/SkPDFCanon.h
diff --git a/src/pdf/SkPDFCanon.h b/src/pdf/SkPDFCanon.h
new file mode 100644
index 0000000000000000000000000000000000000000..424ffb32a43b1c3e21b338848fc36936bf3b46f2
--- /dev/null
+++ b/src/pdf/SkPDFCanon.h
@@ -0,0 +1,77 @@
+/*
+ * Copyright 2015 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+#ifndef SkPDFCanon_DEFINED
+#define SkPDFCanon_DEFINED
+
+#include "SkThread.h"
+#include "SkTDArray.h"
+
+class SkBaseMutex;
+class SkIRect;
+class SkMatrix;
+class SkPDFFont;
+class SkPDFGraphicState;
+class SkPDFShader;
+class SkPDFShaderState;
+class SkPaint;
+class SkShader;
+class SkTypeface;
+
+// This class's fields and methods will eventually become part of
+// SkPDFDocument/SkDocument_PDF. For now, it exists as a singleton to
+// preflight that transition. This replaces three global arrays in
+// SkPDFFont, SkPDFShader, and SkPDFGraphicsContext.
+//
+// Note that this class does not create, delete, reference or
+// dereference the SkPDFObject objects that it indexes. It is up to
+// the caller to manage the lifetime of these objects.
+class SkPDFCanon {
+public:
+ static SkPDFCanon& GetCanon();
+
+ // This mutexes will be removed once this class is subsumed into
+ // SkPDFDocument.
mtklein 2015/01/20 21:59:51 Let's be louder about how much of a minefield this
hal.canary 2015/01/21 17:07:50 Done.
+ static SkBaseMutex& GetFontMutex();
+ static SkBaseMutex& GetShaderMutex();
+ static SkBaseMutex& GetPaintMutex();
+
+ SkPDFFont* findFont(uint32_t fontID,
mtklein 2015/01/20 21:59:51 Add a brief comment for this? The others look str
hal.canary 2015/01/21 17:07:50 Done.
+ uint16_t glyphID,
+ SkPDFFont** relatedFont) const;
+ void addFont(SkPDFFont* font, uint32_t fontID, uint16_t fGlyphID);
+ void removeFont(SkPDFFont*);
+
+ SkPDFShader* findShader(const SkPDFShaderState&) const;
+ void addShader(SkPDFShader*);
+ void removeShader(SkPDFShader*);
+
+ SkPDFGraphicState* findGraphicState(const SkPaint&) const;
+ void addGraphicState(SkPDFGraphicState*);
+ void removeGraphicState(SkPDFGraphicState*);
+
+private:
+ struct FontRec {
+ SkPDFFont* fFont;
+ uint32_t fFontID;
+ uint16_t fGlyphID;
+ };
+ SkTDArray<FontRec> fFontRecords;
+
+ SkTDArray<SkPDFShader*> fShaderRecords;
+
+ SkTDArray<SkPDFGraphicState*> fGraphicStateRecords;
+
+ SkBaseMutex* fFontMutex;
djsollen 2015/01/21 14:10:27 why pointers to global variables? if the cannon is
mtklein 2015/01/21 15:14:40 I missed this the first time around. I too don't
hal.canary 2015/01/21 17:07:50 Acknowledged.
hal.canary 2015/01/21 17:07:50 I forgot to delete those.
+ SkBaseMutex* fShaderMutex;
+ SkBaseMutex* fPaintMutex;
+
+ SkPDFCanon();
+ ~SkPDFCanon();
+ static SkPDFCanon* Create();
djsollen 2015/01/21 14:10:27 Any reason to expose the Create/Destroy functions
mtklein 2015/01/21 15:14:40 I believe this allows the constructor and destruct
hal.canary 2015/01/21 17:07:50 Acknowledged.
hal.canary 2015/01/21 17:07:50 I needed to because I made the constructor private
+ static void Destroy(SkPDFCanon*);
+};
+#endif // SkPDFCanon_DEFINED
« no previous file with comments | « gyp/pdf.gypi ('k') | src/pdf/SkPDFCanon.cpp » ('j') | src/pdf/SkPDFCanon.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698