Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.
Issue 842233003: Push API: Require user visible notification, else show auto notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@invalid
Patch Set: Tweak comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index b679e8fa5d612c7698246d6cd71c238ef7dded22..df4f0b492530c6f7b6182d0e2db2b7c59cbf99b8 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -15020,6 +15020,14 @@ Do you accept?
<message name="IDS_PUSH_MESSAGES_BUBBLE_FRAGMENT" desc="Question asked on the info bar whenever a domain wants to send push messages">
push notifications
</message>
+ <if expr="enable_notifications">
+ <message name="IDS_PUSH_MESSAGING_GENERIC_NOTIFICATION_TITLE" desc="Title of the generic notification shown automatically when a site has received a push message, but failed to show/update/close a notification. Its purpose is both to inform users that new content may be available somewhere on that site, and so the user is aware that the website did something in the background.">
Peter Beverloo 2015/01/09 18:46:25 "Title of an auto-generated notification informing
johnme 2015/01/09 19:27:18 Done.
+ Website updated
Peter Beverloo 2015/01/09 18:46:25 Didn't we want to include the website's host in th
johnme 2015/01/09 19:27:18 Done.
+ </message>
+ <message name="IDS_PUSH_MESSAGING_GENERIC_NOTIFICATION_BODY" desc="Text of the generic notification shown automatically when a site has received a push message, but failed to show/update/close a notification. Its purpose is both to inform users that new content may be available somewhere on that site, and so the user is aware that the website did something in the background.">
+ A site updated in the background.
Peter Beverloo 2015/01/09 18:46:25 If we either display the origin in the title, or d
johnme 2015/01/09 19:27:18 Done.
+ </message>
+ </if>
<!-- Copresence settings/debug strings -->
<if expr="not is_android and not is_ios">

Powered by Google App Engine
This is Rietveld 408576698