merge to XFA: Fix -Wnon-virtual-dtor compiler warnings.

fpdfsdk/include/fxedit/fx_edit.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef _FX_EDIT_H_
 #define _FX_EDIT_H_
 
 #define PVTWORD_STYLE_NORMAL                            0x0000L
@@ skipping 26 matching lines @@
 class IFX_Edit_Iterator;
 class IFX_Edit_UndoItem;
 class IFX_Edit;
 class IFX_List_Notify;
 class IFX_List;
 class IFX_SystemHandler;
 
 class IFX_Edit_FontMap
 {
 public:
+        virtual ~IFX_Edit_FontMap() { }
         //map a fontindex to pdf font.
         virtual CPDF_Font *                                             GetPDFFont(FX_INT32 nFontIndex) = 0;
         //get the alias of a pdf font.
         virtual CFX_ByteString                                  GetPDFFontAlias(FX_INT32 nFontIndex) = 0;
         //get the index of a font that can show a word.
         virtual FX_INT32                                                GetWordFontIndex(FX_WORD word, FX_INT32 charset, FX_INT32 nFontIndex) = 0;
         //get the charcode of word from unicode
         virtual FX_INT32                                                CharCodeFromUnicode(FX_INT32 nFontIndex, FX_WORD word) = 0;
         //get the charset of unicode
         virtual FX_INT32                                                CharSetFromUnicode(FX_WORD word, FX_INT32 nOldCharset) = 0;
 };
 
 class IFX_Edit_Notify
 {
-        //this class is implemented by user
 public:
+        virtual ~IFX_Edit_Notify() { }
         //set the horizontal scrollbar information.
         virtual void                                                    IOnSetScrollInfoX(FX_FLOAT fPlateMin, FX_FLOAT fPlateMax, 
                                                                                                 FX_FLOAT fContentMin, FX_FLOAT fContentMax, 
                                                                                                 FX_FLOAT fSmallStep, FX_FLOAT fBigStep) = 0;
         //set the vertical scrollbar information.
         virtual void                                                    IOnSetScrollInfoY(FX_FLOAT fPlateMin, FX_FLOAT fPlateMax, 
                                                                                                 FX_FLOAT fContentMin, FX_FLOAT fContentMax, 
                                                                                                 FX_FLOAT fSmallStep, FX_FLOAT fBigStep) = 0;
         //set the position of horizontal scrollbar.
         virtual void                                                    IOnSetScrollPosX(FX_FLOAT fx) = 0;
         //set the position of vertical scrollbar.
         virtual void                                                    IOnSetScrollPosY(FX_FLOAT fy) = 0;
         //set the caret information.
         virtual void                                                    IOnSetCaret(FX_BOOL bVisible,const CPDF_Point & ptHead,const CPDF_Point & ptFoot, const CPVT_WordPlace& place) = 0;
         //if the caret position is changed ,send the information of current postion to user.
         virtual void                                                    IOnCaretChange(const CPVT_SecProps & secProps, const CPVT_WordProps & wordProps) = 0;
         //if the text area is changed, send the information to user.
         virtual void                                                    IOnContentChange(const CPDF_Rect& rcContent) = 0;
         //Invalidate the rectangle relative to the bounding box of edit.
         virtual void                                                    IOnInvalidateRect(CPDF_Rect * pRect) = 0;
 };
 
 class IFX_Edit_OprNotify
 {
-        //this class is implemented by user
 public:
+        virtual ~IFX_Edit_OprNotify() { }
+
         //OprType: 0
         virtual void                                                    OnInsertWord(const CPVT_WordPlace& place, const CPVT_WordPlace& oldplace) = 0;
         //OprType: 1
         virtual void                                                    OnInsertReturn(const CPVT_WordPlace& place, const CPVT_WordPlace& oldplace) = 0;
         //OprType: 2
         virtual void                                                    OnBackSpace(const CPVT_WordPlace& place, const CPVT_WordPlace& oldplace) = 0;
         //OprType: 3
         virtual void                                                    OnDelete(const CPVT_WordPlace& place, const CPVT_WordPlace& oldplace) = 0;
         //OprType: 4
         virtual void                                                    OnClear(const CPVT_WordPlace& place, const CPVT_WordPlace& oldplace) = 0;
@@ skipping 37 matching lines @@
         //get the current position.
         virtual const CPVT_WordPlace &                  GetAt() const = 0;
 
         //get the edit which this iterator belongs to
         virtual IFX_Edit*                                               GetEdit() const = 0;
 };
 
 class IFX_Edit_UndoItem
 {
 public:
+        virtual void                                                    Release() = 0;
         virtual void                                                    Undo() = 0;
         virtual void                                                    Redo() = 0;
         virtual CFX_WideString                                  GetUndoTitle() = 0;
-        virtual void                                                    Release() = 0;
+
+protected:
+        ~IFX_Edit_UndoItem() { }
 };
 
 class FXET_CLASS IFX_Edit
 {
 public:
         static IFX_Edit*                                                NewEdit();
         static  void                                                    DelEdit(IFX_Edit* pEdit);
 
-public:
-        //set a IFX_Edit_FontMap pointer implemented by user.
+        //set a IFX_Edit_FontMap pointer implemented by user.
         virtual void                                                    SetFontMap(IFX_Edit_FontMap* pFontMap) = 0;
         //if user don't like to use FontMap, implement VTProvider and set it directly.
         virtual void                                                    SetVTProvider(IPDF_VariableText_Provider* pProvider) = 0;
         //set a IFX_Edit_Notify pointer implemented by user.
         virtual void                                                    SetNotify(IFX_Edit_Notify * pNotify) = 0;
         virtual void                                                    SetOprNotify(IFX_Edit_OprNotify* pOprNotify) = 0;
         //get a pointer allocated by CPDF_Edit, by this pointer, user can iterate the contents of edit, but don't need to release.
         virtual IFX_Edit_Iterator*                              GetIterator() = 0;
         //get a VT pointer relative to this edit.
         virtual IPDF_VariableText*                              GetVariableText() = 0;
@@ skipping 194 matching lines @@
         virtual FX_BOOL                                                 IsTextFull() const = 0;
         virtual FX_BOOL                                                 CanUndo() const = 0;
         virtual FX_BOOL                                                 CanRedo() const = 0;
         //if the content is changed after settext?
         virtual FX_BOOL                                                 IsModified() const = 0;
         //get the total words in edit
         virtual FX_INT32                                                GetTotalWords() const = 0;
 
         virtual void                                                    AddUndoItem(IFX_Edit_UndoItem* pUndoItem) = 0;
 
-public:
         static CFX_ByteString                                   GetEditAppearanceStream(IFX_Edit* pEdit, const CPDF_Point & ptOffset, 
                                                                                                         const CPVT_WordRange* pRange = NULL, 
                                                                                                         FX_BOOL bContinuous = TRUE, FX_WORD SubWord = 0);
         static CFX_ByteString                                   GetSelectAppearanceStream(IFX_Edit* pEdit, const CPDF_Point & ptOffset, const CPVT_WordRange* pRange = NULL);
         static void                                                             DrawEdit(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device, IFX_Edit* pEdit, FX_COLORREF crTextFill, FX_COLORREF crTextStroke,
                                                                                                         const CPDF_Rect& rcClip, const CPDF_Point& ptOffset, const CPVT_WordRange* pRange, IFX_SystemHandler* pSystemHandler, void* pFFLData);
         static void                                                             DrawUnderline(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device, IFX_Edit* pEdit, FX_COLORREF color,
                                                                                                         const CPDF_Rect& rcClip, const CPDF_Point& ptOffset, const CPVT_WordRange* pRange);
         static void                                                             DrawRichEdit(CFX_RenderDevice* pDevice, CPDF_Matrix* pUser2Device, IFX_Edit* pEdit,  
                                                                                                         const CPDF_Rect& rcClip, const CPDF_Point& ptOffset, const CPVT_WordRange* pRange);
         static void                                                             GeneratePageObjects(CPDF_PageObjects* pPageObjects, IFX_Edit* pEdit,
                                                                                                         const CPDF_Point& ptOffset, const CPVT_WordRange* pRange, FX_COLORREF crText, CFX_ArrayTemplate<CPDF_TextObject*>& ObjArray);
         static void                                                             GenerateRichPageObjects(CPDF_PageObjects* pPageObjects, IFX_Edit* pEdit,
                                                                                                         const CPDF_Point& ptOffset, const CPVT_WordRange* pRange, CFX_ArrayTemplate<CPDF_TextObject*>& ObjArray);
         static void                                                             GenerateUnderlineObjects(CPDF_PageObjects* pPageObjects, IFX_Edit* pEdit,
                                                                                                         const CPDF_Point& ptOffset, const CPVT_WordRange* pRange, FX_COLORREF color);
+
+protected:
+    ~IFX_Edit() { }
 };
 
 class IFX_List_Notify
 {
-        //this class is implemented by user
 public:
+        virtual ~IFX_List_Notify() { }
         //set the horizontal scrollbar information.
         virtual void                                                    IOnSetScrollInfoX(FX_FLOAT fPlateMin, FX_FLOAT fPlateMax, 
                                                                                                 FX_FLOAT fContentMin, FX_FLOAT fContentMax, 
                                                                                                 FX_FLOAT fSmallStep, FX_FLOAT fBigStep) = 0;
         //set the vertical scrollbar information.
         virtual void                                                    IOnSetScrollInfoY(FX_FLOAT fPlateMin, FX_FLOAT fPlateMax, 
                                                                                                 FX_FLOAT fContentMin, FX_FLOAT fContentMax, 
                                                                                                 FX_FLOAT fSmallStep, FX_FLOAT fBigStep) = 0;
         //set the position of horizontal scrollbar.
         virtual void                                                    IOnSetScrollPosX(FX_FLOAT fx) = 0;
         //set the position of vertical scrollbar.
         virtual void                                                    IOnSetScrollPosY(FX_FLOAT fy) = 0;
         //Invalidate the rectangle relative to the bounding box of edit.
         virtual void                                                    IOnInvalidateRect(CPDF_Rect * pRect) = 0;
 };
 
 class FXET_CLASS IFX_List
 {
 public:
         static IFX_List*                                                NewList();
         static void                                                             DelList(IFX_List* pList);
 
-public:
         virtual void                                                    SetFontMap(IFX_Edit_FontMap * pFontMap) = 0;
         virtual void                                                    SetNotify(IFX_List_Notify * pNotify) = 0;
 
         virtual void                                                    SetPlateRect(const CPDF_Rect & rect) = 0;
         virtual void                                                    SetFontSize(FX_FLOAT fFontSize) = 0;
 
         virtual CPDF_Rect                                               GetPlateRect() const = 0;
         virtual CPDF_Rect                                               GetContentRect() const = 0;
 
         virtual FX_FLOAT                                                GetFontSize() const = 0;
@@ skipping 28 matching lines @@
         virtual void                                                    OnMouseDown(const CPDF_Point & point,FX_BOOL bShift,FX_BOOL bCtrl) = 0;
         virtual void                                                    OnMouseMove(const CPDF_Point & point,FX_BOOL bShift,FX_BOOL bCtrl) = 0;
         virtual void                                                    OnVK_UP(FX_BOOL bShift,FX_BOOL bCtrl) = 0;
         virtual void                                                    OnVK_DOWN(FX_BOOL bShift,FX_BOOL bCtrl) = 0;
         virtual void                                                    OnVK_LEFT(FX_BOOL bShift,FX_BOOL bCtrl) = 0;
         virtual void                                                    OnVK_RIGHT(FX_BOOL bShift,FX_BOOL bCtrl) = 0;
         virtual void                                                    OnVK_HOME(FX_BOOL bShift,FX_BOOL bCtrl) = 0;
         virtual void                                                    OnVK_END(FX_BOOL bShift,FX_BOOL bCtrl) = 0;
         virtual void                                                    OnVK(FX_INT32 nItemIndex,FX_BOOL bShift,FX_BOOL bCtrl) = 0;
         virtual FX_BOOL                                                 OnChar(FX_WORD nChar,FX_BOOL bShift,FX_BOOL bCtrl) = 0;
+
+protected:
+        ~IFX_List() { }
 };
 
-#endif 
+#endif