Add a tri-state enum to return the result of Xattr operations.

util/mac/xattr_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 39 matching lines @@
 
  private:
   ScopedTempDir temp_dir_;
   base::FilePath path_;
 };
 
 const char kKey[] = "com.google.crashpad.test";
 
 TEST_F(Xattr, ReadNonExistentXattr) {
   std::string value;
-  EXPECT_FALSE(ReadXattr(path(), kKey, &value));
+  EXPECT_EQ(XattrStatus::kNoAttribute, ReadXattr(path(), kKey, &value));
 }
 
 TEST_F(Xattr, WriteAndReadString) {
   std::string value = "hello world";
   EXPECT_TRUE(WriteXattr(path(), kKey, value));
 
   std::string actual;
-  EXPECT_TRUE(ReadXattr(path(), kKey, &actual));
+  EXPECT_EQ(XattrStatus::kOK, ReadXattr(path(), kKey, &actual));
   EXPECT_EQ(value, actual);
 }
 
 TEST_F(Xattr, WriteAndReadVeryLongString) {
   std::string value(533, 'A');
   EXPECT_TRUE(WriteXattr(path(), kKey, value));
 
   std::string actual;
-  EXPECT_TRUE(ReadXattr(path(), kKey, &actual));
+  EXPECT_EQ(XattrStatus::kOK, ReadXattr(path(), kKey, &actual));
   EXPECT_EQ(value, actual);
 }
 
 TEST_F(Xattr, WriteAndReadBool) {
   EXPECT_TRUE(WriteXattrBool(path(), kKey, true));
   bool actual = false;
-  EXPECT_TRUE(ReadXattrBool(path(), kKey, &actual));
+  EXPECT_EQ(XattrStatus::kOK, ReadXattrBool(path(), kKey, &actual));
   EXPECT_TRUE(actual);
 
   EXPECT_TRUE(WriteXattrBool(path(), kKey, false));
-  EXPECT_TRUE(ReadXattrBool(path(), kKey, &actual));
+  EXPECT_EQ(XattrStatus::kOK, ReadXattrBool(path(), kKey, &actual));
   EXPECT_FALSE(actual);
 }
 
 TEST_F(Xattr, WriteAndReadInt) {
   int expected = 42;
   int actual;
 
   EXPECT_TRUE(WriteXattrInt(path(), kKey, expected));
-  EXPECT_TRUE(ReadXattrInt(path(), kKey, &actual));
+  EXPECT_EQ(XattrStatus::kOK, ReadXattrInt(path(), kKey, &actual));
   EXPECT_EQ(expected, actual);
 
   expected = std::numeric_limits<int>::max();
   EXPECT_TRUE(WriteXattrInt(path(), kKey, expected));
-  EXPECT_TRUE(ReadXattrInt(path(), kKey, &actual));
+  EXPECT_EQ(XattrStatus::kOK, ReadXattrInt(path(), kKey, &actual));
   EXPECT_EQ(expected, actual);
 }
 
 TEST_F(Xattr, WriteAndReadTimeT) {
   time_t expected = time(nullptr);
   time_t actual;
 
   EXPECT_TRUE(WriteXattrTimeT(path(), kKey, expected));
-  EXPECT_TRUE(ReadXattrTimeT(path(), kKey, &actual));
+  EXPECT_EQ(XattrStatus::kOK, ReadXattrTimeT(path(), kKey, &actual));
   EXPECT_EQ(expected, actual);
 
   expected = std::numeric_limits<time_t>::max();
   EXPECT_TRUE(WriteXattrTimeT(path(), kKey, expected));
-  EXPECT_TRUE(ReadXattrTimeT(path(), kKey, &actual));
+  EXPECT_EQ(XattrStatus::kOK, ReadXattrTimeT(path(), kKey, &actual));
   EXPECT_EQ(expected, actual);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad