Add a tri-state enum to return the result of Xattr operations.

Add a tri-state enum to return the result of Xattr operations.

R=mark@chromium.org
TEST=util_test --gtest_filter=Xattr\*

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/f0b9dcba25c26d83375faf1bbc75eb7d6a7baf9f

[Robert Sesek, 2015-01-09 17:36:57]

Patchset #1 (id:1) has been deleted

[Mark Mentovai, 2015-01-09 17:52:35]

https://codereview.chromium.org/842223003/diff/20001/util/mac/xattr.h
File util/mac/xattr.h (right):

https://codereview.chromium.org/842223003/diff/20001/util/mac/xattr.h#newcode27
util/mac/xattr.h:27: //! \brief The result code for an ReadXattr or WriteXattr
operation.
I don’t think you need to use these for WriteXattr, let’s just leave that as
bool true/false.

https://codereview.chromium.org/842223003/diff/20001/util/mac/xattr.h#newcode28
util/mac/xattr.h:28: enum class XattrStatus {
Our second one of these. Nice!

https://codereview.chromium.org/842223003/diff/20001/util/mac/xattr.h#newcode31
util/mac/xattr.h:31: //! \brief The attribute does not exist. No message is
logged.
Space these out with blanks.

[Robert Sesek, 2015-01-09 17:59:19]

Patchset #2 (id:40001) has been deleted

[Robert Sesek, 2015-01-09 17:59:40]

https://codereview.chromium.org/842223003/diff/20001/util/mac/xattr.h
File util/mac/xattr.h (right):

https://codereview.chromium.org/842223003/diff/20001/util/mac/xattr.h#newcode27
util/mac/xattr.h:27: //! \brief The result code for an ReadXattr or WriteXattr
operation.
On 2015/01/09 17:52:35, Mark Mentovai wrote:
> I don’t think you need to use these for WriteXattr, let’s just leave that as
> bool true/false.

Done.

https://codereview.chromium.org/842223003/diff/20001/util/mac/xattr.h#newcode28
util/mac/xattr.h:28: enum class XattrStatus {
On 2015/01/09 17:52:35, Mark Mentovai wrote:
> Our second one of these. Nice!

Third, actually :)

https://codereview.chromium.org/842223003/diff/20001/util/mac/xattr.h#newcode31
util/mac/xattr.h:31: //! \brief The attribute does not exist. No message is
logged.
On 2015/01/09 17:52:35, Mark Mentovai wrote:
> Space these out with blanks.

Done.

[Mark Mentovai, 2015-01-09 18:00:49]

LGTM

[Robert Sesek, 2015-01-09 18:04:39]

Committed patchset #2 (id:50004) manually as
f0b9dcba25c26d83375faf1bbc75eb7d6a7baf9f (presubmit successful).