third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 842193004: [css-grid] Handle alignment with orthogonal flows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 842193004: [css-grid] Handle alignment with orthogonal flows (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@orthogonal-flows

Patch Set: Patch rebased. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index 2b7f531231f44fba6c4270a07ab86968c9e71a77..0a20d33f2ad240faf4ea89cf8147e3066acacc3f 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -165,6 +165,8 @@ private:

const GridTrackSize& rawGridTrackSize(GridTrackSizingDirection, size_t) const;

GridTrackSize gridTrackSize(GridTrackSizingDirection, size_t, SizingOperation = TrackSizing) const;

+ bool childOverflowingContainingBlockWidth(const LayoutBox&) const;

+ bool childOverflowingContainingBlockHeight(const LayoutBox&) const;

svillar 2016/07/13 09:00:40 These two names suggest that the functions are ret

jfernandez 2016/07/14 09:29:15 Acknowledged.

bool updateOverrideContainingBlockContentSizeForChild(LayoutBox&, GridTrackSizingDirection, GridSizingData&);

LayoutUnit logicalHeightForChild(LayoutBox&, GridSizingData&);

LayoutUnit minSizeForChild(LayoutBox&, GridTrackSizingDirection, GridSizingData&);