Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 842163002: LoginDatabase::AddLogin should handle correctly incorrect input. (Closed)

Created:
5 years, 11 months ago by vasilii
Modified:
5 years, 11 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LoginDatabase::AddLogin should handle correctly incorrect input. When the input form violates the database's constraints the method should return an empty PasswordStoreChangeList. BUG=396900 Committed: https://crrev.com/4eeca3a20fca6bbb9d048895cac1b2c540b3f01d Cr-Commit-Position: refs/heads/master@{#310762}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix LoginDatabaseTest.* #

Patch Set 3 : fix PasswordStoreTest.StartSyncFlare #

Patch Set 4 : DoesMatchConstraints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -12 lines) Patch
M components/password_manager/core/browser/login_database.cc View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 1 5 chunks +39 lines, -12 lines 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vasilii
Hi Vaclav, please review.
5 years, 11 months ago (2015-01-09 10:19:26 UTC) #2
vabr (Chromium)
lgtm https://codereview.chromium.org/842163002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/842163002/diff/1/components/password_manager/core/browser/login_database.cc#newcode121 components/password_manager/core/browser/login_database.cc:121: bool IsMatchConstraints(const PasswordForm& form) { nit: IsMatchConstraints sounds ...
5 years, 11 months ago (2015-01-09 10:44:19 UTC) #3
vasilii
https://codereview.chromium.org/842163002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/842163002/diff/1/components/password_manager/core/browser/login_database.cc#newcode121 components/password_manager/core/browser/login_database.cc:121: bool IsMatchConstraints(const PasswordForm& form) { On 2015/01/09 10:44:19, vabr ...
5 years, 11 months ago (2015-01-09 11:27:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842163002/60001
5 years, 11 months ago (2015-01-09 11:29:05 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-09 12:34:23 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 12:35:21 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/4eeca3a20fca6bbb9d048895cac1b2c540b3f01d
Cr-Commit-Position: refs/heads/master@{#310762}

Powered by Google App Engine
This is Rietveld 408576698