src/debug.cc - Issue 842153004: Unify phantom and internal fields weak handle callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 842153004: Unify phantom and internal fields weak handle callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Require callback to reset handle. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index 93ef1cfc0973939388f18eb876e021b02a588de5..e3cadda38e227b542e9d77135d42c39dad05d205 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -716,7 +716,7 @@ DebugInfoListNode::DebugInfoListNode(DebugInfo* debug_info): next_(NULL) {

debug_info_ = Handle<DebugInfo>::cast(global_handles->Create(debug_info));

typedef PhantomCallbackData<void>::Callback Callback;

GlobalHandles::MakePhantom(

- reinterpret_cast<Object**>(debug_info_.location()), this,

+ reinterpret_cast<Object**>(debug_info_.location()), this, 0,

reinterpret_cast<Callback>(Debug::HandlePhantomDebugInfo));

}