Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: Source/core/html/HTMLInputElement.h

Issue 842153002: Click event should be fired before change events for checkbox and radio button. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 // Returns true if the type is button, reset, or submit. 88 // Returns true if the type is button, reset, or submit.
89 bool isTextButton() const; 89 bool isTextButton() const;
90 // Returns true if the type is email, number, password, search, tel, text, 90 // Returns true if the type is email, number, password, search, tel, text,
91 // or url. 91 // or url.
92 bool isTextField() const; 92 bool isTextField() const;
93 93
94 bool isImage() const; 94 bool isImage() const;
95 95
96 bool checked() const { return m_isChecked; } 96 bool checked() const { return m_isChecked; }
97 void setChecked(bool, TextFieldEventBehavior = DispatchNoEvent); 97 void setChecked(bool, TextFieldEventBehavior = DispatchNoEvent);
98 void dispatchChangeEventIfNeeded();
98 99
99 // 'indeterminate' is a state independent of the checked state that causes t he control to draw in a way that hides the actual state. 100 // 'indeterminate' is a state independent of the checked state that causes t he control to draw in a way that hides the actual state.
100 bool indeterminate() const { return m_isIndeterminate; } 101 bool indeterminate() const { return m_isIndeterminate; }
101 void setIndeterminate(bool); 102 void setIndeterminate(bool);
102 // shouldAppearChecked is used by the rendering tree/CSS while checked() is used by JS to determine checked state 103 // shouldAppearChecked is used by the rendering tree/CSS while checked() is used by JS to determine checked state
103 bool shouldAppearChecked() const; 104 bool shouldAppearChecked() const;
104 virtual bool shouldAppearIndeterminate() const override; 105 virtual bool shouldAppearIndeterminate() const override;
105 106
106 int size() const; 107 int size() const;
107 bool sizeShouldIncludeDecoration(int& preferredSize) const; 108 bool sizeShouldIncludeDecoration(int& preferredSize) const;
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 // The ImageLoader must be owned by this element because the loader code ass umes 386 // The ImageLoader must be owned by this element because the loader code ass umes
386 // that it lives as long as its owning element lives. If we move the loader into 387 // that it lives as long as its owning element lives. If we move the loader into
387 // the ImageInput object we may delete the loader while this element lives o n. 388 // the ImageInput object we may delete the loader while this element lives o n.
388 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader; 389 OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader;
389 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r; 390 OwnPtrWillBeMember<ListAttributeTargetObserver> m_listAttributeTargetObserve r;
390 }; 391 };
391 392
392 } // namespace blink 393 } // namespace blink
393 394
394 #endif // HTMLInputElement_h 395 #endif // HTMLInputElement_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/forms/radio/radio-group-keyboard-change-event-expected.txt ('k') | Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698