Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: sky/engine/platform/scroll/Scrollbar.h

Issue 842113005: Delete a bunch of noop paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/scroll/ScrollableArea.cpp ('k') | sky/engine/platform/scroll/Scrollbar.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/scroll/Scrollbar.h
diff --git a/sky/engine/platform/scroll/Scrollbar.h b/sky/engine/platform/scroll/Scrollbar.h
index 0fc93552eed7f4a7f7a1b9e1e0eedea44855afd3..8fcf3c7bed5405d08338e937f9534169d4e190dd 100644
--- a/sky/engine/platform/scroll/Scrollbar.h
+++ b/sky/engine/platform/scroll/Scrollbar.h
@@ -47,8 +47,6 @@ public:
virtual ~Scrollbar();
- void invalidateRect(const IntRect&);
-
ScrollbarOverlayStyle scrollbarOverlayStyle() const;
bool isScrollableAreaActive() const;
@@ -61,9 +59,6 @@ public:
int totalSize() const { return m_totalSize; }
int maximum() const { return m_totalSize - m_visibleSize; }
- ScrollbarPart pressedPart() const { return m_pressedPart; }
- ScrollbarPart hoveredPart() const { return m_hoveredPart; }
-
bool enabled() const { return m_enabled; }
void setEnabled(bool);
@@ -109,15 +104,6 @@ public:
static int scrollbarThickness();
- void invalidateParts()
- {
- invalidatePart(BackTrackPart);
- invalidatePart(ThumbPart);
- invalidatePart(ForwardTrackPart);
- }
-
- void invalidatePart(ScrollbarPart);
-
// The position of the thumb relative to the track.
int thumbPosition();
// The length of the thumb along the axis of the scrollbar.
@@ -143,8 +129,6 @@ public:
protected:
Scrollbar(ScrollableArea*, ScrollbarOrientation);
- void updateThumb();
-
void autoscrollTimerFired(Timer<Scrollbar>*);
void startTimerIfNeeded(double delay);
void stopTimerIfNeeded();
@@ -160,6 +144,8 @@ protected:
float m_currentPos;
float m_dragOrigin;
+ // FIXME(sky): Does any of this hovered/pressed tracking do anything
+ // since we only have overlay scrollbars?
ScrollbarPart m_hoveredPart;
ScrollbarPart m_pressedPart;
int m_pressedPos;
« no previous file with comments | « sky/engine/platform/scroll/ScrollableArea.cpp ('k') | sky/engine/platform/scroll/Scrollbar.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698