sky/engine/platform/Widget.h - Issue 842113005: Delete a bunch of noop paint invalidation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/platform/Widget.h

Issue 842113005: Delete a bunch of noop paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: fix comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/platform/Widget.h

diff --git a/sky/engine/platform/Widget.h b/sky/engine/platform/Widget.h

index f55445565f5188e9ad7748e078a1ca6902ec179c..d0485dd2f596b82b539f352f7d433030939ebd63 100644

--- a/sky/engine/platform/Widget.h

+++ b/sky/engine/platform/Widget.h

@@ -63,8 +63,8 @@ public:

void move(const IntPoint& p) { setFrameRect(IntRect(p, size())); }

virtual void paint(GraphicsContext*, const IntRect&) { }

- void invalidate() { invalidateRect(boundsRect()); }

- virtual void invalidateRect(const IntRect&) = 0;

+ // FIXME(sky): Remove

+ void invalidate() { }

virtual bool isFrameView() const { return false; }

virtual bool isScrollbar() const { return false; }