Upstream CompositorButton, VirtualView and TitleBitmapFactory

chrome/android/java/res/values/dimens.xml

Index: chrome/android/java/res/values/dimens.xml
diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml
index cb860da972248827c7d791db101d43efadf76e61..ae85777bbccd2070f54406464ee2483c27d2e5a1 100644
--- a/chrome/android/java/res/values/dimens.xml
+++ b/chrome/android/java/res/values/dimens.xml
@@ -113,4 +113,15 @@
     <!-- Tooltip x margin for text bubble -->
     <dimen name="bubble_tip_margin">8dp</dimen>
 
+    <!-- Compositor Tab Title Dimensions -->
+    <dimen name="compositor_tab_title_bar_shadow_x_offset">0.6667dp</dimen>            <!-- 1px hdpi -->

[Changwan Ryu, 2015/01/12 09:35:26]

line limit? (all the following lines, too)

[Jaekyun Seok (inactive), 2015/01/12 10:04:01]

Is there any specific length limit?

[Changwan Ryu, 2015/01/12 10:15:46]

Hmm... Never mind. The copyright statement keeps it at 80, but I don't think
there is a consistent line limit applied to xml files.

+    <dimen name="compositor_tab_title_bar_shadow_y_offset">0.6667dp</dimen>            <!-- 1px hdpi -->
+    <dimen name="compositor_tab_title_bar_shadow_x_offset_incognito">-0.6667dp</dimen> <!-- -1px hdpi -->
+    <dimen name="compositor_tab_title_bar_shadow_y_offset_incognito">-0.6667dp</dimen> <!-- -1px hdpi -->
+    <!-- The size of the text for tab titles. -->
+    <dimen name="compositor_tab_title_text_size">13dp</dimen>
+    <!-- The size of the boudning box for favicons. -->
+    <dimen name="compositor_tab_title_favicon_size">16dp</dimen>
+    <!-- TabSwitcher - Slop value for allowing slight misses on the compositor button. -->
+    <dimen name="compositor_button_slop">10dp</dimen>

[Changwan Ryu, 2015/01/12 09:35:26]

This seems not specific to tab switcher. Could you remove TabSwitcher from the
comment?

[Jaekyun Seok (inactive), 2015/01/12 10:04:01]

I will.

 </resources>