Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 842063002: Update {virtual,override,final} for chrome/browser/recovery to follow C++11 style. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} for chrome/browser/recovery to follow C++11 style. This patch was automatically generated using a variation of https://codereview.chromium.org/598073004 BUG=417463 Committed: https://crrev.com/3538e8bc5f7d75b15fe6288d17998b5d0d495080 Cr-Commit-Position: refs/heads/master@{#310691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M chrome/browser/recovery/recovery_install_global_error.h View 1 chunk +20 lines, -20 lines 0 comments Download
M chrome/browser/recovery/recovery_install_global_error_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 11 months ago (2015-01-08 23:43:51 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-09 01:42:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842063002/1
5 years, 11 months ago (2015-01-09 01:43:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 02:56:46 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 02:58:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3538e8bc5f7d75b15fe6288d17998b5d0d495080
Cr-Commit-Position: refs/heads/master@{#310691}

Powered by Google App Engine
This is Rietveld 408576698