Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 842053003: YouCompleteMe workaround: explicitly include system include dirs (Closed)

Created:
5 years, 11 months ago by johnme
Modified:
5 years, 10 months ago
CC:
chromium-reviews, eroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@ycm_symlinks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

YouCompleteMe workaround: explicitly include system include dirs This patch is a workaround for https://github.com/Valloric/YouCompleteMe/issues/303 It fixes various issues where standard headers cannot be found, such as: https://groups.google.com/a/google.com/d/msg/ycm-users/TF9dqx0G0N8/bUQPR0jON80J Committed: https://crrev.com/8d6edba93eabb17429944ab6ea0bf302daf1c9ff Cr-Commit-Position: refs/heads/master@{#312363}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Avoid needless isdir("") #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M tools/vim/chromium.ycm_extra_conf.py View 1 2 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 25 (8 generated)
johnme
5 years, 11 months ago (2015-01-19 23:08:28 UTC) #2
eroman
LGTM Also cc-ed Nico who would actually understand the clang side of this. Seems odd ...
5 years, 11 months ago (2015-01-21 02:33:01 UTC) #4
Nico
Wow, this is horrible. From looking at the upstream bug, it sounds like nobody has ...
5 years, 11 months ago (2015-01-21 02:40:59 UTC) #6
johnme
Nico wrote: > Wow, this is horrible. From looking at the upstream bug, it sounds ...
5 years, 11 months ago (2015-01-21 12:23:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842053003/20001
5 years, 11 months ago (2015-01-21 12:26:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 14:26:58 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8d6edba93eabb17429944ab6ea0bf302daf1c9ff Cr-Commit-Position: refs/heads/master@{#312363}
5 years, 11 months ago (2015-01-21 14:28:08 UTC) #15
eroman
Hmm, I get the following error when including these extra headers: use of undeclared identifier ...
5 years, 10 months ago (2015-02-05 20:07:20 UTC) #16
johnme
On 2015/02/05 20:07:20, eroman wrote: > Hmm, I get the following error when including these ...
5 years, 10 months ago (2015-02-05 20:42:30 UTC) #17
eroman
On Thu, Feb 5, 2015 at 12:42 PM, <johnme@chromium.org> wrote: > On 2015/02/05 20:07:20, eroman ...
5 years, 10 months ago (2015-02-05 20:58:34 UTC) #18
johnme
On 2015/02/05 20:58:34, eroman wrote: > On Thu, Feb 5, 2015 at 12:42 PM, <mailto:johnme@chromium.org> ...
5 years, 10 months ago (2015-02-05 21:03:35 UTC) #19
eroman
No clue. I am using the clang that is bundled with chromium. And libclang in ...
5 years, 10 months ago (2015-02-05 21:12:47 UTC) #20
Nico
On 2015/02/05 21:03:35, johnme wrote: > On 2015/02/05 20:58:34, eroman wrote: > > On Thu, ...
5 years, 10 months ago (2015-02-05 21:14:51 UTC) #21
johnme
On 2015/02/05 21:14:51, Nico wrote: > On 2015/02/05 21:03:35, johnme wrote: > /work/src/chromegit/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.6.0/include > > ...
5 years, 10 months ago (2015-02-05 21:21:11 UTC) #22
Nico
Maybe the ycm config should point ycm at our clang? …I think ycm maybe needs ...
5 years, 10 months ago (2015-02-05 21:22:30 UTC) #23
dzhioev (left Google)
On 2015/02/05 21:21:11, johnme wrote: > On 2015/02/05 21:14:51, Nico wrote: > > On 2015/02/05 ...
5 years, 10 months ago (2015-02-06 12:45:32 UTC) #24
dzhioev (left Google)
5 years, 10 months ago (2015-02-06 12:54:38 UTC) #25
Message was sent while issue was closed.
On 2015/02/06 12:45:32, dzhioev wrote:
> On 2015/02/05 21:21:11, johnme wrote:
> > On 2015/02/05 21:14:51, Nico wrote:
> > > On 2015/02/05 21:03:35, johnme wrote:
> > >
> >
>
/work/src/chromegit/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.6.0/include
> > > 
> > > That's the clang binary that every engineer on Chromium uses. (Except on
> > > Windows. On Android it's only used for host builds.)
> > 
> > Which clang is YouCompleteMe using? My patch just uses whichever clang is on
> the
> > PATH*, when getting the include directories; if that's different from the
> clang
> > that YCM uses it would make sense for things to go wrong.
> > 
> > *: (as observed from that Python script, so it may or may not include paths
> > added in .bashrc)
> 
> By default YouCompleteMe downloads prebuild copy of libclang.so and uses it
for
> completion.
Version of libclang is specified in YCM's CMakeFile. See here:
https://github.com/Valloric/ycmd/blob/master/cpp/ycm/CMakeLists.txt#L56

Powered by Google App Engine
This is Rietveld 408576698