Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: build/android/gyp/java_cpp_enum_tests.py

Issue 842043003: Use parens in multilne C++ -> Java enum generator directives. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/java_cpp_enum.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/java_cpp_enum_tests.py
diff --git a/build/android/gyp/java_cpp_enum_tests.py b/build/android/gyp/java_cpp_enum_tests.py
index 3ad218928cac7f960ae95d0759aca6522f561cb9..75e6671ed1616f4601dc07090f9ac7d60609f683 100755
--- a/build/android/gyp/java_cpp_enum_tests.py
+++ b/build/android/gyp/java_cpp_enum_tests.py
@@ -225,8 +225,8 @@ public class ClassName {
def testParseSimpleMultiLineDirective(self):
test_data = """
- // GENERATED_JAVA_ENUM_PACKAGE: \\
- // test.namespace
+ // GENERATED_JAVA_ENUM_PACKAGE: (
+ // test.namespace)
// GENERATED_JAVA_CLASS_NAME_OVERRIDE: Bar
enum Foo {
FOO_A,
@@ -238,9 +238,9 @@ public class ClassName {
def testParseMultiLineDirective(self):
test_data = """
- // GENERATED_JAVA_ENUM_PACKAGE: te\\
- // st.name\\
- // space
+ // GENERATED_JAVA_ENUM_PACKAGE: (te
+ // st.name
+ // space)
enum Foo {
FOO_A,
};
@@ -250,11 +250,12 @@ public class ClassName {
def testParseMultiLineDirectiveWithOtherDirective(self):
test_data = """
- // GENERATED_JAVA_ENUM_PACKAGE: \\
- // test.namespace
- // GENERATED_JAVA_CLASS_NAME_OVERRIDE: \\
- // Ba\\
+ // GENERATED_JAVA_ENUM_PACKAGE: (
+ // test.namespace)
+ // GENERATED_JAVA_CLASS_NAME_OVERRIDE: (
+ // Ba
// r
+ // )
enum Foo {
FOO_A,
};
@@ -265,9 +266,9 @@ public class ClassName {
def testParseMalformedMultiLineDirectiveWithOtherDirective(self):
test_data = """
- // GENERATED_JAVA_ENUM_PACKAGE: \\
- // test.name\\
- // space\\
+ // GENERATED_JAVA_ENUM_PACKAGE: (
+ // test.name
+ // space
// GENERATED_JAVA_CLASS_NAME_OVERRIDE: Bar
enum Foo {
FOO_A,
@@ -278,9 +279,9 @@ public class ClassName {
def testParseMalformedMultiLineDirective(self):
test_data = """
- // GENERATED_JAVA_ENUM_PACKAGE: \\
- // test.name\\
- // space\\
+ // GENERATED_JAVA_ENUM_PACKAGE: (
+ // test.name
+ // space
enum Foo {
FOO_A,
};
@@ -290,7 +291,7 @@ public class ClassName {
def testParseMalformedMultiLineDirectiveShort(self):
test_data = """
- // GENERATED_JAVA_ENUM_PACKAGE: \\
+ // GENERATED_JAVA_ENUM_PACKAGE: (
enum Foo {
FOO_A,
};
« no previous file with comments | « build/android/gyp/java_cpp_enum.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698