build/android/gyp/java_cpp_enum.py - Issue 842043003: Use parens in multilne C++ -> Java enum generator directives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/java_cpp_enum.py

Issue 842043003: Use parens in multilne C++ -> Java enum generator directives. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/gyp/java_cpp_enum.py

diff --git a/build/android/gyp/java_cpp_enum.py b/build/android/gyp/java_cpp_enum.py

index 09cf853dc13f4ea9aa255005c37effb49d586f64..46417eca5e6735a1413256bad7c21588c0bca1af 100755

--- a/build/android/gyp/java_cpp_enum.py

+++ b/build/android/gyp/java_cpp_enum.py

@@ -125,11 +125,11 @@ class HeaderParser(object):

generator_directive_re = re.compile(

r'^\s*//\s+GENERATED_JAVA_(\w+)\s*:\s*([\.\w]+)$')

multi_line_generator_directive_start_re = re.compile(

- r'^\s*//\s+GENERATED_JAVA_(\w+)\s*:\s*([\.\w]*)\\$')

+ r'^\s*//\s+GENERATED_JAVA_(\w+)\s*:\s*\(([\.\w]*)$')

multi_line_directive_continuation_re = re.compile(

- r'^\s*//\s+([\.\w]+)\\$')

+ r'^\s*//\s+([\.\w]+)$')

multi_line_directive_end_re = re.compile(

- r'^\s*//\s+([\.\w]*)$')

+ r'^\s*//\s+([\.\w]*)\)$')

optional_class_or_struct_re = r'(class|struct)?'

enum_name_re = r'(\w+)'

« no previous file with comments | « no previous file | build/android/gyp/java_cpp_enum_tests.py » ('j') | no next file with comments »