Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 842043003: Use parens in multilne C++ -> Java enum generator directives. (Closed)

Created:
5 years, 11 months ago by mkosiba (inactive)
Modified:
5 years, 11 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use parens in multilne C++ -> Java enum generator directives. Backslashes in comments produce a compile error (as the compiler interprets them as 'multi-line single-line comments'). This requires a different way of denoting mulit-line directives. Parens seem like a reasonably natural syntax for this. BUG=None TEST=java_cpp_enum_tests.py R=jbudorick@chromium.org Committed: https://crrev.com/2f65eb2d9c327d2bd93d079b7b6c2924e1959df5 Cr-Commit-Position: refs/heads/master@{#311073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M build/android/gyp/java_cpp_enum.py View 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/gyp/java_cpp_enum_tests.py View 6 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842043003/1
5 years, 11 months ago (2015-01-12 17:01:43 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-12 17:01:44 UTC) #4
jbudorick
lgtm
5 years, 11 months ago (2015-01-12 17:05:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842043003/1
5 years, 11 months ago (2015-01-12 17:08:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 18:40:08 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 18:40:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f65eb2d9c327d2bd93d079b7b6c2924e1959df5
Cr-Commit-Position: refs/heads/master@{#311073}

Powered by Google App Engine
This is Rietveld 408576698