Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 842033005: Make Bigint instances immutable by removing all setters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 43482)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -3318,23 +3318,6 @@
load->set_recognized_kind(kind);
return ReturnDefinition(load);
}
- case MethodRecognizer::kBigint_setDigits: {
- Value* receiver = Bind(BuildLoadThisVar(node->scope()));
- LocalVariable* value_var =
- node->scope()->LookupVariable(Symbols::Value(), true);
- ASSERT(value_var != NULL);
- Value* value = Bind(new(I) LoadLocalInstr(*value_var));
- StoreInstanceFieldInstr* store = new(I) StoreInstanceFieldInstr(
- Bigint::digits_offset(),
- receiver,
- value,
- kEmitStoreBarrier,
- node->token_pos());
- Do(store);
- ConstantInstr* null_const = new(I) ConstantInstr(
- Object::ZoneHandle(I, Object::null()));
- return ReturnDefinition(null_const);
- }
case MethodRecognizer::kBigint_getUsed: {
Value* receiver = Bind(BuildLoadThisVar(node->scope()));
LoadFieldInstr* load = new(I) LoadFieldInstr(
@@ -3346,23 +3329,6 @@
load->set_recognized_kind(kind);
return ReturnDefinition(load);
}
- case MethodRecognizer::kBigint_setUsed: {
- Value* receiver = Bind(BuildLoadThisVar(node->scope()));
- LocalVariable* value_var =
- node->scope()->LookupVariable(Symbols::Value(), true);
- ASSERT(value_var != NULL);
- Value* value = Bind(new(I) LoadLocalInstr(*value_var));
- StoreInstanceFieldInstr* store = new(I) StoreInstanceFieldInstr(
- Bigint::used_offset(),
- receiver,
- value,
- kNoStoreBarrier,
- node->token_pos());
- Do(store);
- ConstantInstr* null_const = new(I) ConstantInstr(
- Object::ZoneHandle(I, Object::null()));
- return ReturnDefinition(null_const);
- }
case MethodRecognizer::kBigint_getNeg: {
Value* receiver = Bind(BuildLoadThisVar(node->scope()));
LoadFieldInstr* load = new(I) LoadFieldInstr(
@@ -3374,23 +3340,6 @@
load->set_recognized_kind(kind);
return ReturnDefinition(load);
}
- case MethodRecognizer::kBigint_setNeg: {
- Value* receiver = Bind(BuildLoadThisVar(node->scope()));
- LocalVariable* value_var =
- node->scope()->LookupVariable(Symbols::Value(), true);
- ASSERT(value_var != NULL);
- Value* value = Bind(new(I) LoadLocalInstr(*value_var));
- StoreInstanceFieldInstr* store = new(I) StoreInstanceFieldInstr(
- Bigint::neg_offset(),
- receiver,
- value,
- kEmitStoreBarrier,
- node->token_pos());
- Do(store);
- ConstantInstr* null_const = new(I) ConstantInstr(
- Object::ZoneHandle(I, Object::null()));
- return ReturnDefinition(null_const);
- }
default:
break;
}

Powered by Google App Engine
This is Rietveld 408576698