Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 842033004: Remove custom element :unresolved. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove custom element :unresolved. Sky doesn't do upgrades and unknown elements become <error> so this doesn't make sense. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a8ca8c23b390bb8c38d66e1ae07dcec6eb3aa74c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M sky/engine/core/css/CSSSelector.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSSelector.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
lgtm
5 years, 11 months ago (2015-01-17 00:01:38 UTC) #2
esprehn
5 years, 11 months ago (2015-01-17 01:50:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8ca8c23b390bb8c38d66e1ae07dcec6eb3aa74c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698