Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 842003002: Re-land: base: Fix DiscardableSharedMemory::mapped_size(). (Closed)

Created:
5 years, 11 months ago by reveman
Modified:
5 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: base: Fix DiscardableSharedMemory::mapped_size(). Set |mapped_size_| to 0 after unmapping memory. BUG=429416 TEST=base_unittests --gtest_filter=DiscardableSharedMemoryTest.MappedSize Committed: https://crrev.com/6e3fb363a511053170e5b019c733dd75ad406100 Cr-Commit-Position: refs/heads/master@{#311051}

Patch Set 1 #

Patch Set 2 : add unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M base/memory/discardable_shared_memory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
reveman
This is what made https://codereview.chromium.org/793443003/ cause crashes and get reverted. Please take a look.
5 years, 11 months ago (2015-01-08 19:44:42 UTC) #2
danakj
Can you run this by Avi also?
5 years, 11 months ago (2015-01-08 19:45:40 UTC) #4
danakj
On 2015/01/08 19:44:42, reveman wrote: > This is what made https://codereview.chromium.org/793443003/ cause crashes and > ...
5 years, 11 months ago (2015-01-08 19:45:54 UTC) #5
reveman
added a unit test. ptal.
5 years, 11 months ago (2015-01-08 19:57:40 UTC) #6
danakj
Thanks, LGTM % avi
5 years, 11 months ago (2015-01-08 20:02:08 UTC) #7
Avi (use Gerrit)
On 2015/01/08 20:02:08, danakj wrote: > Thanks, LGTM % avi S LGTM
5 years, 11 months ago (2015-01-08 21:18:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842003002/20001
5 years, 11 months ago (2015-01-08 21:41:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 23:26:50 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/95bc5b1779dcf8e4a9e37ef600c0ea76293307e3 Cr-Commit-Position: refs/heads/master@{#310625}
5 years, 11 months ago (2015-01-08 23:27:47 UTC) #12
pennymac
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/810433003/ by pennymac@google.com. ...
5 years, 11 months ago (2015-01-10 00:24:02 UTC) #13
reveman
On 2015/01/10 00:24:02, pennymac wrote: > A revert of this CL (patchset #2 id:20001) has ...
5 years, 11 months ago (2015-01-12 15:21:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/842003002/20001
5 years, 11 months ago (2015-01-12 15:22:20 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-12 15:32:44 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 15:33:37 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e3fb363a511053170e5b019c733dd75ad406100
Cr-Commit-Position: refs/heads/master@{#311051}

Powered by Google App Engine
This is Rietveld 408576698