Make unix socket Get{Peer|Local}Address return more rational errors.

Make unix socket Get{Peer|Local}Address return more rational errors.

Rather than return ERR_NOT_IMPLEMENTED it seems sensible to
return ERR_SOCKET_NOT_CONNECTED in the case that the socket
is not connected, but unconditionally return ERR_ADDRESS_INVALID
if connected (because there's no IP addr or port associated
with either end of the socket).

BUG=431412
Committed: https://crrev.com/ff494028c4d918f24ced2b718369ae194748d300
Cr-Commit-Position: refs/heads/master@{#310564}

[tobiasjs, 2015-01-08 16:34:30]

tobiasjs@google.com changed reviewers:
+ rsleevi@chromium.org

[tobiasjs, 2015-01-08 16:34:31]

Hi Ryan,

Could you please comment on whether this is a sensible way to get rid of the
ERR_NOT_IMPLEMENTED return here in favour of something a bit more sensible.

The bug is fixed either way by an earlier cl, but this seems like the right
thing to do?

Thanks,
Toby.

[tobiasjs, 2015-01-08 18:00:30]

cc'ing mmenke and byungchul with an alternative fix for BUG=431412

[mmenke, 2015-01-08 18:15:52]

mmenke@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2015-01-08 18:15:53]

LGTM

https://codereview.chromium.org/841993002/diff/1/net/socket/unix_domain_clien...
File net/socket/unix_domain_client_socket_posix.cc (right):

https://codereview.chromium.org/841993002/diff/1/net/socket/unix_domain_clien...
net/socket/unix_domain_client_socket_posix.cc:108: }
nit:  Don't use braces for if's when both the "if" line and the body only have
one line each

https://codereview.chromium.org/841993002/diff/1/net/socket/unix_domain_clien...
net/socket/unix_domain_client_socket_posix.cc:119: }
nit:  Remove braces.

[tobiasjs, 2015-01-08 18:42:57]

The CQ bit was checked by tobiasjs@google.com

[commit-bot: I haz the power, 2015-01-08 18:44:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/841993002/20001

[byungchul, 2015-01-08 18:48:25]

byungchul@chromium.org changed reviewers:
+ byungchul@chromium.org

[byungchul, 2015-01-08 18:48:25]

lgtm

Thank you for fix.

[commit-bot: I haz the power, 2015-01-08 19:41:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-08 19:42:55]

Patchset 2 (id:??) landed as
https://crrev.com/ff494028c4d918f24ced2b718369ae194748d300
Cr-Commit-Position: refs/heads/master@{#310564}