IDL: Support iterable<>, maplike<> and setlike<> syntax

Source/bindings/scripts/idl_definitions.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 252 matching lines @@
 class IdlInterface(object):
     def __init__(self, idl_name, node=None):
         self.attributes = []
         self.constants = []
         self.constructors = []
         self.custom_constructors = []
         self.extended_attributes = {}
         self.operations = []
         self.parent = None
         self.stringifier = None
+        self.iterable = None
+        self.maplike = None
+        self.setlike = None
         self.original_interface = None
         self.partial_interfaces = []
         if not node:  # Early exit for IdlException.__init__
             return
 
         self.is_callback = node.GetProperty('CALLBACK') or False
         self.is_exception = False
         # FIXME: uppercase 'Partial' => 'PARTIAL' in base IDL parser
         self.is_partial = node.GetProperty('Partial') or False
         self.idl_name = idl_name
@@ skipping 13 matching lines @@
                     extended_attributes_to_constructors(idl_name, extended_attributes))
                 clear_constructor_attributes(extended_attributes)
                 self.extended_attributes = extended_attributes
             elif child_class == 'Operation':
                 self.operations.append(IdlOperation(idl_name, child))
             elif child_class == 'Inherit':
                 self.parent = child.GetName()
             elif child_class == 'Stringifier':
                 self.stringifier = IdlStringifier(idl_name, child)
                 self.process_stringifier()
+            elif child_class == 'Iterable':
+                self.iterable = IdlIterable(idl_name, child)
+            elif child_class == 'Maplike':
+                self.maplike = IdlMaplike(idl_name, child)
+            elif child_class == 'Setlike':
+                self.setlike = IdlSetlike(idl_name, child)
             else:
                 raise ValueError('Unrecognized node class: %s' % child_class)
 
+        if len(filter(None, [self.iterable, self.maplike, self.setlike])) > 1:
+            raise ValueError('Interface can only have one of iterable<>, maplike<> and setlike<>.')
+
     def resolve_typedefs(self, typedefs):
         for attribute in self.attributes:
             attribute.resolve_typedefs(typedefs)
         for constant in self.constants:
             constant.resolve_typedefs(typedefs)
         for constructor in self.constructors:
             constructor.resolve_typedefs(typedefs)
         for custom_constructor in self.custom_constructors:
             custom_constructor.resolve_typedefs(typedefs)
         for operation in self.operations:
@@ skipping 311 matching lines @@
                 raise ValueError('Unrecognized node class: %s' % child_class)
 
         # Copy the stringifier's extended attributes (such as [Unforgable]) onto
         # the underlying attribute or operation, if there is one.
         if self.attribute or self.operation:
             (self.attribute or self.operation).extended_attributes.update(
                 self.extended_attributes)
 
 
 ################################################################################
+# Iterable, Maplike, Setlike
+################################################################################
+
+class IdlIterable(object):
+    def __init__(self, idl_name, node):
+        children = node.GetChildren()
+
+        if len(children) == 1:
+            self.key_type = None
+            self.value_type = type_node_to_type(children[0])
+        elif len(children) == 2:
+            self.key_type = type_node_to_type(children[0])
+            self.value_type = type_node_to_type(children[1])
+        else:
+            raise ValueError('Unexpected number of children: %d' % len(children))
+
+
+class IdlMaplike(object):
+    def __init__(self, idl_name, node):
+        self.is_read_only = node.GetProperty('READONLY') or False

[yhirano, 2015/01/09 02:30:01]

bool(node.GetProperty('READONLY'))

[Jens Widell, 2015/01/09 07:15:04]

Done.

I had simply copied this from IdlAttribute, and it matched how all other boolean
properties were accessed, but since I agree bool() is better, I changed this and
all other boolean property accesses to use bool().

+
+        children = node.GetChildren()
+
+        if len(children) == 2:
+            self.key_type = type_node_to_type(children[0])
+            self.value_type = type_node_to_type(children[1])
+        else:
+            raise ValueError('Unexpected number of children: %d' % len(children))
+
+
+class IdlSetlike(object):
+    def __init__(self, idl_name, node):
+        self.is_read_only = node.GetProperty('READONLY') or False

[yhirano, 2015/01/09 02:30:01]

ditto

[Jens Widell, 2015/01/09 07:15:04]

Done.

+
+        children = node.GetChildren()
+
+        if len(children) == 1:
+            self.value_type = type_node_to_type(children[0])
+        else:
+            raise ValueError('Unexpected number of children: %d' % len(children))
+
+
+################################################################################
 # Implement statements
 ################################################################################
 
 class IdlImplement(object):
     def __init__(self, node):
         self.left_interface = node.GetName()
         self.right_interface = node.GetProperty('REFERENCE')
 
 
 ################################################################################
@@ skipping 210 matching lines @@
     child_class = child.GetClass()
     if child_class != 'Type':
         raise ValueError('Unrecognized node class: %s' % child_class)
     return type_node_to_type(child)
 
 
 def union_type_node_to_idl_union_type(node):
     member_types = [type_node_to_type(member_type_node)
                     for member_type_node in node.GetChildren()]
     return IdlUnionType(member_types)