Fix unsafe unaligned accesses in the serializer/deserializer.

Fix unsafe unaligned accesses in the serializer/deserializer.

R=svenpanne@chromium.org
BUG=v8:3771
LOG=N

Committed: https://crrev.com/d06f1db31f4903ffb6bfddd0bfc4acfb367cff79
Cr-Commit-Position: refs/heads/master@{#25995}

[Sven Panne, 2015-01-08 12:01:23]

https://codereview.chromium.org/841943002/diff/1/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/841943002/diff/1/src/serialize.cc#newcode619
src/serialize.cc:619: memcpy(&r, res.begin() + i, sizeof(r));
Use start() instead of begin(). The fact that the iterator is actually a real
pointer is an implementation detail.

https://codereview.chromium.org/841943002/diff/1/src/serialize.h
File src/serialize.h (right):

https://codereview.chromium.org/841943002/diff/1/src/serialize.h#newcode460
src/serialize.h:460: Reservation() : reservation_(0) {}
Why do we need this?

[Yang, 2015-01-08 12:43:27]

https://codereview.chromium.org/841943002/diff/1/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/841943002/diff/1/src/serialize.cc#newcode619
src/serialize.cc:619: memcpy(&r, res.begin() + i, sizeof(r));
On 2015/01/08 12:01:23, Sven Panne wrote:
> Use start() instead of begin(). The fact that the iterator is actually a real
> pointer is an implementation detail.

Done.

https://codereview.chromium.org/841943002/diff/1/src/serialize.h
File src/serialize.h (right):

https://codereview.chromium.org/841943002/diff/1/src/serialize.h#newcode460
src/serialize.h:460: Reservation() : reservation_(0) {}
On 2015/01/08 12:01:23, Sven Panne wrote:
> Why do we need this?

Thanks for catching this. This was necessary in a previous iteration. Not
necessary anymore. Removed.

[Sven Panne, 2015-01-08 12:50:40]

The CQ bit was checked by svenpanne@chromium.org

[Sven Panne, 2015-01-08 12:50:40]

lgtm

[commit-bot: I haz the power, 2015-01-08 12:51:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/841943002/20001

[commit-bot: I haz the power, 2015-01-08 13:18:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-08 13:19:06]

Patchset 2 (id:??) landed as
https://crrev.com/d06f1db31f4903ffb6bfddd0bfc4acfb367cff79
Cr-Commit-Position: refs/heads/master@{#25995}